Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkdeclarative #110

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#343

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#343
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • 在CheckBox、RadioButton和Switch组件中,使用anchors.centerIn: parent可能会导致子组件的布局出现问题,应确保这种布局方式是必要的并且不会影响用户界面。
  • 在Switch组件中,将sourceSize.widthsourceSize.height替换为widthheight,以及sourceSize的值设置为Qt.size(DS.Style.switchButton.handleWidth, DS.Style.switchButton.handleHeight)可能是为了简化代码,但需要确保这一改动不会破坏现有的布局和样式。

合并相似的问题是否建议立即修改:

  • 是,建议立即修改以确保代码的整洁性、可读性和布局的预期效果。特别是布局相关的改动,需要确保不会引入新的布局问题。

@18202781743 18202781743 merged commit 2692917 into master May 13, 2024
9 of 11 checks passed
@18202781743 18202781743 deleted the sync-pr-343-nosync branch May 13, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants