Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(qtdbus): first time cannot such object path #31

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(qtdbus): first time cannot such object path #31

merged 1 commit into from
May 7, 2024

Conversation

Groveer
Copy link
Contributor

@Groveer Groveer commented May 7, 2024

as title

Log:

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在initThread函数中，qDbusConnection().registerService(policy->name);这行代码被移除后，再次被加回，这可能是一个重复代码的问题。
  • qCInfo和qCWarning日志函数的使用可能会在生产环境中泄露敏感信息，应该考虑是否在提交前进行敏感信息过滤。

是否建议立即修改:

  • 是，应该避免重复代码，并且注意日志信息的安全性。

@Groveer Groveer requested a review from justforlxz May 7, 2024 01:46
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Groveer, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Groveer Groveer merged commit e15b893 into linuxdeepin:master May 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justforlxz justforlxz justforlxz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Groveer @deepin-ci-robot @justforlxz