Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加dock栏鼠标悬停item背景加深 #874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xinguankeli
Copy link

@xinguankeli xinguankeli commented Jun 10, 2023

dock栏鼠标悬停item背景加深

Log: 增加dock栏鼠标悬停item背景加深


edit by maintainer:

mmexport1686380141410_Trim.mp4

效果视频,视频由原作者提供

@github-actions
Copy link

github-actions bot commented Jun 10, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@xinguankeli
Copy link
Author

I have read the CLA Document and I hereby sign the CLA.

@Decodetalkers
Copy link
Contributor

/recheck

@Decodetalkers
Copy link
Contributor

recheck

deepin-bot bot added a commit to linuxdeepin/cla that referenced this pull request Jun 10, 2023
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个有涉及对现有行为的调整,请详细描述下变动前和变动后的行为差异,以便于产品/设计人员评估是否可以合入相关变动,或提供配置项并保持默认行为为原有行为。

@@ -23,6 +23,7 @@ QPointer<DockPopupWindow> DockItem::PopupWindow(nullptr);
DockItem::DockItem(QWidget *parent)
: QWidget(parent)
, m_hover(false)
, m_down(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, m_down(false)
, m_pressed(false)

@xinguankeli
Copy link
Author

变动前:在鼠标悬停在dock栏的item上不会绘制一个矩形。
变动后:在鼠标悬停在dock栏的item上就绘制一个矩形。
总结:该功能主要是提升视觉效果。

@xinguankeli
Copy link
Author

recheck

@Decodetalkers
Copy link
Contributor

?你怎么关了

@xinguankeli
Copy link
Author

不是我关的你信不?我还纳闷 怎么没了

@xinguankeli xinguankeli reopened this Jun 10, 2023
dock栏鼠标悬停item背景加深

Log: 增加dock栏鼠标悬停item背景加深
@BLumia BLumia added the suggest | interface style suggest | 控件, 系统界面样式效果的建议 label Jun 10, 2023
Comment on lines +138 to +139
if(m_hover && !m_pressed)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(m_hover && !m_pressed)
{
if (m_hover && !m_pressed) {

Comment on lines +145 to +146
}else if(m_hover && m_pressed)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}else if(m_hover && m_pressed)
{
} else if (m_hover && m_pressed) {

if(m_hover && !m_pressed)
{
QPainter painter(this);
painter.setBrush(QBrush(QColor(248, 248, 255)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个颜色无论亮色与暗色主题均保持同一个颜色吗?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,这个颜色是固定的,无论主题是否变化

@meiyixiang
Copy link
Member

这个问题我,需要先和UI和UED设计沟通一下,他不仅仅是个需求更多涉及交互问题。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 4, 2024

TAG Bot

New tag: 6.0.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #943

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 11, 2024

TAG Bot

New tag: 6.0.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #950

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 18, 2024

TAG Bot

New tag: 6.0.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #962

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 22, 2024

TAG Bot

New tag: 6.0.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #965

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 23, 2024

TAG Bot

New tag: 6.0.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #967

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 24, 2024

TAG Bot

New tag: 6.0.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #971

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 26, 2024

TAG Bot

New tag: 6.0.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #974

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 30, 2024

TAG Bot

New tag: 6.0.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #977

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 30, 2024

TAG Bot

New tag: 6.0.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #984

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 2, 2024

TAG Bot

New tag: 6.0.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #985

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 12, 2024

TAG Bot

New tag: 6.0.36
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #990

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 17, 2024

TAG Bot

New tag: 6.0.37
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggest | interface style suggest | 控件, 系统界面样式效果的建议
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants