Fix todos and fixmes

bin/backlight_helper/ddcci/ddcci.go

@@ -113,11 +113,6 @@ func newDDCCI() (*ddcci, error) {
 		displayHandleMap: make(map[string]*displayHandle),
 	}
 
-	status := C.ddca_init2((*C.char)(unsafe.Pointer(nil)), C.DDCA_SYSLOG_NOTICE, C.DDCA_INIT_OPTIONS_CLIENT_OPENED_SYSLOG, (***C.char)(unsafe.Pointer(nil)))
-	if status < C.int(0) {
-		return nil, fmt.Errorf("brightness: Error ddcci init: %d", status)
-	}
-
 	err := ddc.RefreshDisplays()
 	if err != nil {
 		return nil, err

bin/backlight_helper/ddcci/ddcci_wrapper.c

@@ -28,4 +28,5 @@ int freeAllDisplaysWrapper() {
     if (fp_ddca_free_all_displays) {
         return fp_ddca_free_all_displays();
     }
+    return -1;
 }

keybinding1/manager.go

@@ -930,8 +930,14 @@ func (m *Manager) handleKeyEventByWayland(changKey string) {
 				logger.Warningf("get wireless enabled failed, err: %v", err)
 				return
 			}
-			// FIXME:  修复NM WiFi无法恢复bug, 使快捷键能够恢复WiFi问题
 			if !enabled {
+				type networkDevice struct {
+					InterfaceFlags uint32 `json:"interface_flags"`
+				}
+				// The following code is intended to fix a bug where NetworkManager WiFi
+				// cannot be restored using a shortcut key. It checks if any wireless
+				// network interfaces are down (InterfaceFlags == 0) and, if so,
+				// toggles the wireless adapter off and on to reset the state.
 				if devicesJson, err := m.network.Devices().Get(0); err == nil {
 					networkDevices := make(map[string][]*networkDevice)
 					json.Unmarshal([]byte(devicesJson), &networkDevices)

keybinding1/manager_test.go

@@ -0,0 +1,9 @@
+package keybinding
+
+import (
+	"testing"
+)
+
+func TestFix(t *testing.T) {
+
+}

keybinding1/shortcuts/keystroke.go

@@ -268,8 +268,9 @@ func ParseKeystrokes(keystrokes []string) []*Keystroke {
 		parsed, err := ParseKeystroke(keystroke)
 		if err == nil {
 			result = append(result, parsed)
+		} else {
+			logger.Warningf("failed to parse keystroke %q: %v", keystroke, err)
 		}
-		// TODO else warning
 	}
 	return result
 }

keybinding1/shortcuts/shortcut_manager.go

@@ -469,7 +469,11 @@ func (sm *ShortcutManager) NotifyLayoutChanged() {
 }
 
 func (sm *ShortcutManager) Destroy() {
-	// TODO
+	if sm.dataConn != nil {
+		record.FreeContext(sm.conn, sm.recordContext)
+		sm.dataConn.Close()
+		sm.dataConn = nil
+	}
 }
 
 func (sm *ShortcutManager) List() (list []Shortcut) {
@@ -1238,30 +1242,6 @@ func (sm *ShortcutManager) AddSystem(wmObj wm.Wm) {
 	}
 }
 
-// TODO delete, because not used
-// func (sm *ShortcutManager) AddWM(gsettings *gio.Settings, wmObj wm.Wm) {
-// 	logger.Debug("AddWM")
-// 	idNameMap := getWMIdNameMap()
-// 	releaseType := getDeepinReleaseType()
-// 	for _, id := range gsettings.ListKeys() {
-// 		if releaseType == "Server" && strings.Contains(id, "workspace") {
-// 			logger.Debugf("release type is server filter '%s'", id)
-// 			continue
-// 		}
-// 		if id == "expose-all-windows" || id == "expose-windows" {
-// 			logger.Debugf("'%s' is abandoned!", id)
-// 			continue
-// 		}
-// 		name := idNameMap[id]
-// 		if name == "" {
-// 			name = id
-// 		}
-// 		keystrokes := gsettings.GetStrv(id)
-// 		gs := NewShortcut(wmObj, id, ShortcutTypeWM, keystrokes, name)
-// 		sm.addWithoutLock(gs)
-// 	}
-// }
-
 func (sm *ShortcutManager) AddMedia(wmObj wm.Wm) {
 	logger.Debug("AddMedia")
 	idNameMap := getMediaIdNameMap()