-
Notifications
You must be signed in to change notification settings - Fork 102
chore: remove deprecated resource control module #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR deletes the deprecated cgroup-based resource control module, removing all associated path management, configuration loading, task setup, and cleanup logic as part of legacy code cleanup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The resource control module (cgroup.go) has been deleted as it was deprecated and no longer in use. This module previously handled CPU and memory resource allocation through cgroups but has been superseded by newer implementations. The removal includes: 1. Cgroup path management functions 2. Configuration loading from JSON 3. Task management and cgroup setup logic 4. Periodic cleanup of unused cgroups The deletion reflects ongoing system cleanup and modernization efforts, removing legacy code that could potentially cause confusion or maintenance overhead. No replacement functionality is needed as this was handled at a different system level. Influence: 1. Verify system resource management still functions as expected 2. Check for any processes that might have relied on this cgroup management 3. Ensure no configuration files at /etc/deepin/daemon/resource- control.json are still being read 4. Monitor system performance to confirm no unexpected behavior chore: 移除废弃的资源控制模块 资源控制模块(cgroup.go)已被删除,因为该模块已废弃不再使用。该模块之前通 过cgroups处理CPU和内存资源分配,但已被新的实现所取代。删除内容包括: 1. Cgroup路径管理功能 2. 从JSON加载配置 3. 任务管理和cgroup设置逻辑 4. 定期清理未使用的cgroups 此次删除反映了系统持续清理和现代化的努力,移除了可能导致混淆或维护负担的 遗留代码。不需要替代功能,因为这已在不同的系统层面处理。 Influence: 1. 验证系统资源管理是否仍按预期工作 2. 检查是否有进程可能依赖于此cgroup管理 3. 确保/etc/deepin/daemon/resource-control.json的配置文件不再被读取 4. 监控系统性能以确认没有意外行为
deepin pr auto review根据提供的git diff和代码文件,我发现这是对resource_ctl模块的移除操作。我将从代码质量、性能和安全性等方面对被删除的代码进行分析和评价: 1. 代码质量优点:
不足:
2. 性能优点:
不足:
3. 安全性优点:
不足:
改进建议
总的来说,这个resource_ctl模块虽然实现了基本的功能,但在代码质量、性能和安全性方面还有较大的改进空间。如果需要重新实现这个功能,建议参考上述改进建议进行优化。 |
|
TAG Bot New tag: 6.1.57 |
|
TAG Bot New tag: 6.1.58 |
|
TAG Bot New tag: 6.1.59 |
|
TAG Bot New tag: 6.1.62 |
The resource control module (cgroup.go) has been deleted as it was deprecated and no longer in use. This module previously handled CPU and memory resource allocation through cgroups but has been superseded by newer implementations. The removal includes:
The deletion reflects ongoing system cleanup and modernization efforts, removing legacy code that could potentially cause confusion or maintenance overhead. No replacement functionality is needed as this was handled at a different system level.
Influence:
chore: 移除废弃的资源控制模块
资源控制模块(cgroup.go)已被删除,因为该模块已废弃不再使用。该模块之前通
过cgroups处理CPU和内存资源分配,但已被新的实现所取代。删除内容包括:
此次删除反映了系统持续清理和现代化的努力,移除了可能导致混淆或维护负担的
遗留代码。不需要替代功能,因为这已在不同的系统层面处理。
Influence:
Summary by Sourcery
Chores: