refactor: remove swap scheduler module #915
Open
+1
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed the entire swap scheduler module including: - Main implementation files (swapsched.go) - Auto-generated DBus methods file - Systemd service configuration - DBus configuration files - Test references - Build system references 2. Cleaned up related systemd service configurations 3. Updated RPM spec file to remove swap scheduler references The swap scheduler functionality appears to be deprecated or no longer needed. This change: 1. Simplifies the codebase by removing unused components 2. Reduces maintenance overhead 3. Removes potential security surface area 4. Follows up on previous deprecation steps (note the /bin/false in service file) Influence: 1. Verify system boots correctly without swap scheduler 2. Check no swap scheduler related processes are running 3. Confirm no swap scheduler DBus interfaces are registered 4. Test system resource management continues to work normally 5. Verify no regression in session management functionality refactor: 移除交换调度器模块 1. 移除了整个交换调度器模块，包括： - 主实现文件 (swapsched.go) - 自动生成的DBus方法文件 - Systemd服务配置 - DBus配置文件 - 测试引用 - 构建系统引用 2. 清理了相关的systemd服务配置 3. 更新了RPM spec文件以移除交换调度器引用 交换调度器功能似乎已被弃用或不再需要。此变更： 1. 通过移除未使用的组件简化代码库 2. 减少维护开销 3. 移除潜在的安全攻击面 4. 跟进之前的弃用步骤（注意服务文件中的/bin/false） Influence: 1. 验证系统在没有交换调度器的情况下能正常启动 2. 检查没有交换调度器相关进程在运行 3. 确认没有交换调度器DBus接口被注册 4. 测试系统资源管理功能继续正常工作 5. 验证会话管理功能没有回归
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review根据提供的git diff，我看到这是一个移除swap调度相关功能的变更。我来分析一下这个变更：
总体来看，这个变更移除了swap调度相关的整个功能模块，这是一个较大的架构变更。建议：
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the codebase by removing the deprecated swap scheduler module and all its associated source, configuration, service definitions, and build references to simplify maintenance and reduce the security surface. Entity relationship diagram for DBus service configuration after swap scheduler removalerDiagram
"org.deepin.dde.Power1.service" ||--|| "deepin-accounts-daemon.service" : uses
"org.deepin.dde.Gesture1.service" ||--|| "deepin-accounts-daemon.service" : uses
"org.deepin.dde.Timedated1.service" ||--|| "deepin-accounts-daemon.service" : uses
%% org.deepin.dde.SwapSchedHelper1.service has been removed.
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
TAG Bot New tag: 6.1.57 |
|
TAG Bot New tag: 6.1.58 |
|
TAG Bot New tag: 6.1.59 |
|
TAG Bot New tag: 6.1.62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swap scheduler functionality appears to be deprecated or no longer needed. This change:
Influence:
refactor: 移除交换调度器模块
交换调度器功能似乎已被弃用或不再需要。此变更：
Influence:
Summary by Sourcery
Remove the deprecated swap scheduler module and clean up all related references across the codebase, build and configuration files.
Enhancements:
Build:
Deployment:
Tests: