T420 initial support + X220 FBWhiptail Support #578

snmcmillan · 2019-06-07T00:28:00Z

Separating my original PR #539.
This branch introduces T420 support (complete with FBWhiptail support) and modifications to the X220 to support FBWhiptail.

No known new regressions are present, and this does not fix the 50 second delay that is currently present.

…estarting, or during S3 resume. If they actually bring functionality to builds, replace the patch with something that is tested.

This reverts commit 584690f.

…ng up, restarting, or during S3 resume. If they actually bring functionality to builds, replace the patch with something that is tested." This reverts commit 41e5301.

This reverts commit f17c519.

X220 cbmem temp debug requirements

adds the chip option, needed for X220 to actually use this.

Forgot to disable TPM logging

merge

IMO this should be a seperate PR!

merge

the commit message should better read "blobs/t420: remove gitignore"

merge · 2019-06-07T09:01:41Z

boards/t420/t420.config

+# Configuration for a x220 running Qubes and other OS
+# The Linux configuration is close enough to the x230
+export CONFIG_COREBOOT=y
+CONFIG_COREBOOT_CONFIG=config/coreboot-x220.config


is that correct?

merge · 2019-06-07T09:02:07Z

boards/t420/t420.config

+# The Linux configuration is close enough to the x230
+export CONFIG_COREBOOT=y
+CONFIG_COREBOOT_CONFIG=config/coreboot-x220.config
+CONFIG_LINUX_CONFIG=config/linux-x230.config


if correct, we should add a comment, why, I think

This is correct. If the already existing X220 is close enough to X230, and T420 is close enough to X220, T420 is close enough to X230.

Tested on my T420 as working.

merge

This could be squashed into the previous change that adds t420.config

merge · 2019-06-07T09:03:33Z

boards/t420/t420.config

 export CONFIG_COREBOOT=y
-CONFIG_COREBOOT_CONFIG=config/coreboot-t420.config
+CONFIG_COREBOOT_CONFIG=config/coreboot-T420.config


really uppercase T?

merge

why not do 2 commit when changing 2 board configs?

merge

we need to review this seperately and this has to be a different PR. interesting...

This reverts commit 1e705eb. Reverting that way the new method to obtain flash definitions can be used (seen in osresearch/linuxboot#592)

This reverts commit fe03f79. Revert flash.sh part 2

snmcmillan · 2019-07-06T15:12:32Z

This branch's flash.sh changes are reverted to conform with #592's way of supplying flash definitions.

tlaurion · 2020-01-02T00:48:43Z

@SebastianMcMillan Have you had a chance to test including ifd and reduce me and changing CBFS size in coreboot config and see if the 60 seconds delay linked to ME disappeared?

snmcmillan · 2020-01-02T17:41:31Z

I've not yet had the chance, but I will get around to it by the end of the month.

…

On Wed, Jan 1, 2020, 18:48 tlaurion ***@***.***> wrote: @SebastianMcMillan <https://github.com/SebastianMcMillan> Have you had a chance to test <https://github.com/corna/me_cleaner/wiki/Internal-flashing-with-coreboot#neutralize-and-shrink-intel-me> including ifd and reduce me and changing CBFS size in coreboot config and see if the 60 seconds delay linked to ME disappeared? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#578>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNTUNGROWW6DRHTXOEMT5LQ3U2WXANCNFSM4HVNCJ3Q> .

techge · 2020-01-03T22:22:55Z

@SebastianMcMillan Have you had a chance to test including ifd and reduce me and changing CBFS size in coreboot config and see if the 60 seconds delay linked to ME disappeared?

As mentioned in #539 I followed the guide and truncated the ME, still the boot delay is valid.

techge · 2020-01-03T23:30:42Z

Commenting CONFIG_MEASURED_BOOT here stops the delay. So that means it is a TPM issue, isn't it?

snmcmillan · 2020-01-13T00:14:29Z

I don't believe this is an ME issue. I can use the exact same IFD and ME with stock coreboot and we don't see this issue. Furthermore, using stock ME and IFD still reproduces this issue.

This issue is certainly a 4.8.1 issue. I've tested pre 4.8.1 heads on my X220 and can confirm the issue is not present. At this point, I will wait for heads to be based on 4.11+ and see if it's still an issue.

techge · 2020-01-13T09:37:52Z

I would like to already play around a bit. So may I ask how I could switch to old coreboot in the meantime?

techge · 2020-01-21T13:17:18Z

Okay, I used this PR as a basis for my own branch and combined with the hint from @tlaurion it actually works fine now for me!

Would @SebastianMcMillan like to separate the x220 stuff as I did and create a new PR as this is tested now, shall we wait or shall I create a PR based on the branch I mentioned above?

snmcmillan · 2020-01-21T16:35:48Z

I'll get on that tonight.

…

On Tue, Jan 21, 2020, 07:17 Alexander Paetzelt ***@***.***> wrote: Okay, I used this PR as a basis for my own branch <#578> and combined with the hint <#539 (comment)> from @tlaurion <https://github.com/tlaurion> it actually works fine now for me! Would @SebastianMcMillan <https://github.com/SebastianMcMillan> like to separate the x220 stuff as I did and create a new PR as this is tested now, shall we wait or shall I create a PR based on the branch I mentioned above? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#578>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNTUNADOGDFM47VHHRFOXLQ63YV7ANCNFSM4HVNCJ3Q> .

tlaurion · 2020-02-13T21:54:06Z

@SebastianMcMillan ?

snmcmillan · 2020-02-15T02:25:38Z

I apologize on the delay, my T420 is running into some difficulties, and I've been a little caught up with coursework. I am working on testing @tlaurion's suggestion on the X220 as well.

Fixed Typo for flashrom_options

Added intel_iommu=igfx_off argument

Decreased CBFS size to fix boot delay problems Enabled compiling with any toolchain to prevent build problems Removed check ME option since it fails to check the ME due to the build process not finding me_cleaner

snmcmillan · 2020-02-19T03:48:05Z

T420 and X220 boot delay fixes tested and confirmed working on my end.

Fixed boot delay by decreasing CBFS size, removed dysfunctional check ME option, and enabled use of any toolchain.

snmcmillan and others added 21 commits March 20, 2019 09:14

Add support for the Lenovo ThinkPad T420.

662a1dd

Fix the autodetection of ifdtool and me_cleaner.

94e6e09

Whoops, added the entire directory!

be21220

Actually point to the T420 coreboot config file...

d38190e

Merge branch 'master' of https://github.com/SebastianMcMillan/heads

f2bdd98

Enable FBWhiptail mode for X220 and T420

62d6a6c

Don't use iommu settings because it breaks graphics after kexec.

6fb0a9d

Remove sandybridge patches. Causes 50 second delay when booting up, r…

41e5301

…estarting, or during S3 resume. If they actually bring functionality to builds, replace the patch with something that is tested.

Fixed TPM romstage measurements.

584690f

Turn on iommu, but do not enable igfx-off

04d7df7

Revert "Fixed TPM romstage measurements."

cb74314

This reverts commit 584690f.

Revert "Remove sandybridge patches. Causes 50 second delay when booti…

04b59d2

…ng up, restarting, or during S3 resume. If they actually bring functionality to builds, replace the patch with something that is tested." This reverts commit 41e5301.

One more thing: Add flash.sh definitions for X220 and T420.

fe03f79

Required SPI flash chip option to flahs internally

f17c519

Temporary coreboot config required to debug through cbmem under heads

5a437ea

Revert "Required SPI flash chip option to flahs internally"

f3c8a2d

This reverts commit f17c519.

Merge pull request #2 from tlaurion/x220_cbmem_temp_debug_requirements

68e2c76

X220 cbmem temp debug requirements

Update flash.sh

1e705eb

adds the chip option, needed for X220 to actually use this.

Update x220.config

3c0899f

Update coreboot-x220.config

e356d2d

Update coreboot-x220.config

f60fd69

Forgot to disable TPM logging

techge mentioned this pull request Jun 7, 2019

Add support for T420 and T430, enable FBWhiptail for X220. #539

Closed

merge suggested changes Jun 7, 2019

View reviewed changes

merge reviewed Jun 7, 2019

View reviewed changes

snmcmillan added 2 commits July 6, 2019 10:08

Revert "Update flash.sh"

9b3da5b

This reverts commit 1e705eb. Reverting that way the new method to obtain flash definitions can be used (seen in osresearch/linuxboot#592)

Revert "One more thing: Add flash.sh definitions for X220 and T420."

0e1f36b

This reverts commit fe03f79. Revert flash.sh part 2

snmcmillan mentioned this pull request Jul 23, 2019

Adding flash tools in x220 images #595

Closed

techge added a commit to techge/heads that referenced this pull request Jan 3, 2020

Include x220 files of PR linuxboot#578

6c3a29a

tlaurion mentioned this pull request Feb 16, 2020

kexec can't boot qubes 4.1 iso #672

Closed

snmcmillan added 3 commits February 18, 2020 21:37

Update t420.config

6c7a2ff

Fixed Typo for flashrom_options

Update t420.config

d8c018c

Added intel_iommu=igfx_off argument

Update coreboot-t420.config

dbdf051

Decreased CBFS size to fix boot delay problems Enabled compiling with any toolchain to prevent build problems Removed check ME option since it fails to check the ME due to the build process not finding me_cleaner

snmcmillan added 3 commits February 18, 2020 21:49

Update coreboot-x220.config

52df283

Fixed boot delay by decreasing CBFS size, removed dysfunctional check ME option, and enabled use of any toolchain.

Update t420.config

5c5bca0

Update x220.config

e1e3418

snmcmillan requested a review from tlaurion February 19, 2020 05:34

snmcmillan mentioned this pull request Feb 19, 2020

Romstage TPM measuring cause a 50 second delay on power on, S3 resume and reboot on all sandy/ivy devices except X230. #541

Closed

Merge branch 'master' into t420-initial-support

bac3936

tlaurion approved these changes Feb 19, 2020

View reviewed changes

Remove space in x220 board config prior of FLASHROM_OPTIONS

4afa41b

tlaurion merged commit 21faf52 into linuxboot:master Feb 19, 2020

eganonoa mentioned this pull request Mar 9, 2020

LibremKey/Nitrokey with x220 #690

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

T420 initial support + X220 FBWhiptail Support #578

T420 initial support + X220 FBWhiptail Support #578

snmcmillan commented Jun 7, 2019

merge left a comment

merge left a comment

merge Jun 7, 2019

merge Jun 7, 2019

snmcmillan Jun 7, 2019

merge left a comment

merge Jun 7, 2019

merge left a comment

merge left a comment

snmcmillan commented Jul 6, 2019

tlaurion commented Jan 2, 2020

snmcmillan commented Jan 2, 2020 via email

techge commented Jan 3, 2020

techge commented Jan 3, 2020

snmcmillan commented Jan 13, 2020

techge commented Jan 13, 2020

techge commented Jan 21, 2020 •

edited

Loading

snmcmillan commented Jan 21, 2020 via email

tlaurion commented Feb 13, 2020

snmcmillan commented Feb 15, 2020

snmcmillan commented Feb 19, 2020

T420 initial support + X220 FBWhiptail Support #578

T420 initial support + X220 FBWhiptail Support #578

Conversation

snmcmillan commented Jun 7, 2019

merge left a comment

Choose a reason for hiding this comment

merge left a comment

Choose a reason for hiding this comment

merge Jun 7, 2019

Choose a reason for hiding this comment

merge Jun 7, 2019

Choose a reason for hiding this comment

snmcmillan Jun 7, 2019

Choose a reason for hiding this comment

merge left a comment

Choose a reason for hiding this comment

merge Jun 7, 2019

Choose a reason for hiding this comment

merge left a comment

Choose a reason for hiding this comment

merge left a comment

Choose a reason for hiding this comment

snmcmillan commented Jul 6, 2019

tlaurion commented Jan 2, 2020

snmcmillan commented Jan 2, 2020 via email

techge commented Jan 3, 2020

techge commented Jan 3, 2020

snmcmillan commented Jan 13, 2020

techge commented Jan 13, 2020

techge commented Jan 21, 2020 • edited Loading

snmcmillan commented Jan 21, 2020 via email

tlaurion commented Feb 13, 2020

snmcmillan commented Feb 15, 2020

snmcmillan commented Feb 19, 2020

techge commented Jan 21, 2020 •

edited

Loading