Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CONFIG_GPG=y #508

Merged
merged 1 commit into from
Jan 27, 2019
Merged

remove CONFIG_GPG=y #508

merged 1 commit into from
Jan 27, 2019

Conversation

ThePlexus
Copy link
Contributor

Building make BOARD=x230-flash fails due to size. Removal of CONFIG_GPG fixes this. For further details, see #451

Building make BOARD=x230-flash fails due to size. Removal of CONFIG_GPG fixes this. For further details, see #451
@ThePlexus
Copy link
Contributor Author

for ref, GPG is not required to be used in x230-flash stage. its just bloat.

@ThePlexus
Copy link
Contributor Author

Erm, what a facepalm moment. GPG is needed to sign the coreboot.rom . closing

@ThePlexus ThePlexus closed this Jan 14, 2019
@ThePlexus ThePlexus deleted the patch-1 branch January 14, 2019 19:07
@tlaurion
Copy link
Collaborator

tlaurion commented Jan 15, 2019 via email

@ThePlexus
Copy link
Contributor Author

ThePlexus commented Jan 15, 2019

I guess you could sign coreboot.rom after flashing the 12mb, like this?

  • flash 230-flash
  • flash 12mb coreboot.rom
  • sign 12mb coreboot.rom
  • reflash 12mb coreboot.rom

EDIT have tested this method and it works.

@ThePlexus ThePlexus restored the patch-1 branch January 15, 2019 11:35
@ThePlexus ThePlexus reopened this Jan 15, 2019
@tlaurion
Copy link
Collaborator

tlaurion commented Jan 15, 2019 via email

@ThePlexus
Copy link
Contributor Author

insert it in a reproducible rom with cbfs from heads recovery shell prior to flash it back

This is the bit where my confusion arose. It seemed from the docs that we should sign the 12mb ROM before flashing. In fact, its not the case. Flash the 12Mb, then sign the 12 ROM with cbfs, then flash the 12 ROM again. All fine,was just some confusion yesterday thats all. the process is

flash x230-flash
flash 12mb coreboot.rom
sign 12mb coreboot.rom
reflash 12mb coreboot.rom

@tlaurion
Copy link
Collaborator

tlaurion commented Jan 17, 2019

insert it in a reproducible rom with cbfs from heads recovery shell prior to flash it back

@shamen123 : What is suggested here is to insert your gpg public key in the built reproducible rom ( make BOARD=x230) prior to flashing it from withing Heads (make BOARD=x230-flash, then flash externally)

When using fbwhiptail and using gui-init, a menu offers you to insert your public key. Unfortunately, generating 4096 keys from within Heads requires GPG2.

Unfortunately, generating keys from within x230-flash environment is not possible anymore for size constraints, and even less possible with GPG2 being a requirement to generate 4096bits keys inside of the GPG card.

Waiting for @osresearch merge day patiently :)

Please close the issue if you do not have any more question, as the title of your issue is a duplicate of #451.

A pull request on the documentation is more then welcome though :)

@ThePlexus
Copy link
Contributor Author

This is not a issue, its a pull request to actually make the change to comment out CONFIG_GPG=y

AFAIK, there is no pull request for 451.

@tlaurion
Copy link
Collaborator

tlaurion commented Jan 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants