Iso boot debugging and fixes #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlaurion
force-pushed
the
iso_boot_debugging_and_fixes
branch
from
3af5cf2
to
40872d8
Compare
|
In current state of PR: booting from detached-signed Tinycore 14.0 iso Booting directly boot from qemu pointing to ISO Note that this doesn't resolve the issue of booting into tinycore which doesn't have the DRM+gpu drivers for qemu. |
Comment on lines
220
to
+226
| *) | ||
| kernel="${val#"$bootdir"}" | ||
| kernel="$val" | ||
| DEBUG "kernel= $kernel" | ||
| esac | ||
| ;; | ||
| initrd* | INITRD* ) | ||
| initrd="${val#"$bootdir"}" | ||
| initrd="$val" |
There was a problem hiding this comment.
Since we're undoing part of a075347 - the concern in the commit was fixed right, kexec-boot now handles absolute paths correctly?
There was a problem hiding this comment.
Will review that part.
There was a problem hiding this comment.
Interestingly, a075347 was supposed to be grub related. Without hack in my debugging PR to merge isolinux and grub entries to not have duplicate entries, Debian isolinux entries are exposed without "..." in labels.
Will test.
There was a problem hiding this comment.
@JonathonHall-Purism I haven't found a case where this PR caused issue following past comment
There was a problem hiding this comment.
The current issue in master is that when isos are mounted under /boot, the actual bootdir is /boot/boot/ and that is getting stripped otherwise. I think a075347 was relevant until caller scripts fixed it themselves if needed.
There was a problem hiding this comment.
@tlaurion Sorry this sat in my inbox for a few days. Makes sense, agree it looks like the root issue was fixed. I see what you mean that stripping /boot from /boot/boot/... would cause this issue.
Is this ready to merge then?
| ADD="fromiso=/dev/disk/by-uuid/$DEV_UUID/$ISO_PATH img_dev=/dev/disk/by-uuid/$DEV_UUID iso-scan/filename=/${ISO_PATH} img_loop=$ISO_PATH" | ||
| ADD="fromiso=/dev/disk/by-uuid/$DEV_UUID/$ISO_PATH img_dev=/dev/disk/by-uuid/$DEV_UUID iso-scan/filename=/${ISO_PATH} img_loop=$ISO_PATH iso=$DEV_UUID/$ISO_PATH" |
There was a problem hiding this comment.
Wish there was a bit more of a standard here so we didn't have to spray all the variants we know about 😓 But it looks fine for our purposes
There was a problem hiding this comment.
Will add reference to webboot as comment prior of section. Since this is passed as kernel options down to user land init, passing all iso boot hacks for all linux distributions would be pretty harmless and probably should be done preventively prior if users opening issues... but that would require us to test them all individually :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1347
Fixes #1374
@JonathonHall-Purism please review (this is different then #1351 which will be rebased on this when I have time to continue checking why we cannot have basic simple fb in absence of virtio fb under Tinycore's initrd)
@saper that should fix your issue under x230 with 4.x kernel which doen't suffer from 5.x-> Tinycore novga issue (like on qemu)