Add DEBUG statements in code and fix "sh: argument expected" #1317
Conversation
|
A little bit clearer. Also permits newcomers to simply export CONFIG_DEBUG in board configs to see trace of function calls |
tlaurion
force-pushed
the
fix-sh_argument_expected
branch
from
6dcc53c
to
5e516a6
Compare
|
In current state:
So prior of main gui-init loop |
tlaurion
force-pushed
the
fix-sh_argument_expected
branch
from
5e516a6
to
5d30c2b
Compare
|
While @JonathonHall-Purism let me know what you want to do with that introduced bug! ( I think those 2 commits bundled under this PR is fine, but if you disagree, I can split debug and fix in different PR. Just thought it was nice to show here how a bug like this can be debugged in the future by adding more DEBUG statements in code to be ran on qemu and/or enabled on user computer by injecting config.user overlay through menu options and/or minimal debug functionality from recovery shell by typing |
tlaurion
force-pushed
the
fix-sh_argument_expected
branch
from
5d30c2b
to
fd6daeb
Compare
|
Tested:
|
tlaurion
changed the title
tlaurion
force-pushed
the
fix-sh_argument_expected
branch
2 times, most recently
from
f59f347
to
c894870
Compare
…NFIG_DEBUG_OUTPUT is exported in board config -qemu-coreboot-*whiptail-tpm1(-hotp) boards have 'export CONFIG_DEBUG_OUTPUT=y' by default now
tlaurion
force-pushed
the
fix-sh_argument_expected
branch
from
c894870
to
5fbbbbc
Compare
…, yubikey test regression for oem-factory-reset, optimized for space (03-O2->Os) and fix for sh: argument expected, with local CONFIG_DEBUG_OUTPUT enabled and fused in ROM. Includes linuxboot#1317, linuxboot#1121, linuxboot#1312, linuxboot#1305 for test on daily driver
…ix-sh_argument_expected-yubikey-oem-factory-reset_dasharo-flashrom
Daily driver test fo x230-hotp-maximized on coreboot 4.19, with debug, yubikey test regression for oem-factory-reset, optimized for space (03-O2->Os) and fix for sh: argument expected, with local CONFIG_DEBUG_OUTPUT enabled and fused in ROM.
Includes linuxboot#1317, linuxboot#1121, linuxboot#1312, linuxboot#1305, linuxboot#1251 for test on daily driver
…ix-sh_argument_expected-yubikey-oem-factory-reset_dasharo-flashrom
Daily driver test fo x230-hotp-maximized on coreboot 4.19, with debug, yubikey test regression for oem-factory-reset, optimized for space (03-O2->Os) and fix for sh: argument expected, with local CONFIG_DEBUG_OUTPUT enabled and fused in ROM.
Includes osresearch#1317, osresearch#1121, osresearch#1312, osresearch#1305, osresearch#1251 for test on daily driver
|
Using x230-hotp-maximized from CircleCI builds as of now. Nothing to report as of now as regression. |
- Add TRACE function tracing output under etc/functions, depending on CONFIG_ENABLE_FUNCTION_TRACING_OUTPUT enabled in board configs - Replace current DEBUG to TRACE calls in code, reserving DEBUG calls for more verbose debugging later on (output of variables etc) - add 'export CONFIG_ENABLE_FUNCTION_TRACING_OUTPUT=y' in qemu-coreboot(fb)whiptail-tpm1(-hotp) boards to see it in action
tlaurion
force-pushed
the
fix-sh_argument_expected
branch
from
1ce1f0a
to
8259d3c
Compare
|
Latest commit gives following output when 'export CONFIG_ENABLE_FUNCTION_TRACING_OUTPUT=y' enabled under board config (OP edited)
@JonathonHall-Purism ready for merging? |
|
This looks great, thanks let's merge 👍 |
As noted under #1316, it is sometimes difficult to isolate source of errors/diagnose problems.
This PR introduces:
In current debugging state, we can see that reported #1316 can be isolated under:
