Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usb-scan->media-scan: usb-init calling media-scan usb #1297

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

tlaurion
Copy link
Collaborator

media-scan accepts direct input of existing blkid and mount that passed device to /media

media-scan accepts direct input of existing blkid and mount that passed device to /media
@tlaurion tlaurion marked this pull request as draft January 26, 2023 21:31
@tlaurion

This comment was marked as resolved.

@tlaurion
Copy link
Collaborator Author

Hid last comment since it is due to different options being passed.

@JonathonHall-Purism : please review, since present code change works and permits first steps toward booting from already exposed partitions that could have recovery detached signed ISOs which Heads can boot directly.


The following works:

Recovery shell+ media-scan /dev/sda1
signal-2023-01-27-145917

Selecting ISO:
signal-2023-01-27-145928
Results in detached signature validation being successful, while current Heads's Tails ditribution public key is expired (fixed by #1094)

Selection External HD:
signal-2023-01-27-150007

Boots Tails 5.9 (with
signal-2023-01-27-150045

@tlaurion tlaurion marked this pull request as ready for review January 27, 2023 20:11
@tlaurion
Copy link
Collaborator Author

Also boots Qubes4.1 successfully, meaning that a user could leave a non-boot partition with enough space to keep detached signed ISOs there, as long as he is aware to pass that partition to media-scan. I think this is neat.

@JonathonHall-Purism
Copy link
Collaborator

Looks good, we had a side discussion on possibly factoring out the "how to mount /media" from media-scan but this is a good step. 👍

@tlaurion tlaurion merged commit 7be67e4 into linuxboot:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants