Pmolloy/mdl all the things #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Molloy <[email protected]>
- MD004 Unordered list style - MD005 Inconsistent indentation for list items at the same level - MD013 Line length - MD025 Multiple top level headers in the same document - MD030 Spaces after list markers Signed-off-by: Philip Molloy <[email protected]>
pamolloy
force-pushed
the
pmolloy/mdl-all-the-things
branch
from
c084b60 to
b1bbbd2
Compare
The line length was inconsistent in the two parts of the file. The footnotes will addressed in another commit. Also correct multiple blank lines on line 26. Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
pamolloy
force-pushed
the
pmolloy/mdl-all-the-things
branch
from
b1bbbd2 to
716c505
Compare
- MD013 Line length - MD022 Headers should be surrounded by blank lines Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
- MD013 Line length - MD022 Headers should be surrounded by blank lines - MD032 Lists should be surrounded by blank lines - MD034 Bare URL used - Minor spelling mistake Signed-off-by: Philip Molloy <[email protected]>
- MD013 Line length - MD014 Dollar signs used before commands without showing output - MD031 Fenced code blocks should be surrounded by blank lines Signed-off-by: Philip Molloy <[email protected]>
- MD013 Line length - MD014 Dollar signs used before commands without showing output - MD026 Trailing punctuation in header - MD029 Ordered list item prefix - MD034 Bare URL used - MD036 Emphasis used instead of a header - MD046 Code block style - Fix small spelling mistake - Add syntax highlighting to go code blocks Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
|
Ok, I didn't fix "all the things", but a good effort for now. 😅 |
Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
- "counter-intuitive" is more readable than "counterintuitive" - Use in-line code styling - Remove unnecessary HTML comment - Footnotes do not need a section header since they are at the end of the document Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
- MD001 Header levels should only increment by one level at a time - MD002 First header should be a top level header - MD025 Multiple top level headers in the same document - MD032 Lists should be surrounded by blank lines Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
|
This PR removes 337 out of 539 |
Signed-off-by: Philip Molloy <[email protected]>
Signed-off-by: Philip Molloy <[email protected]>
orangecms
reviewed
Oct 25, 2024
| $ go run github.com/linuxboot/corebootnerf --fetch | ||
| ... lots and lots of output! | ||
| ``` | ||
| $ go get github.com/linuxboot/corebootnerf |
There was a problem hiding this comment.
just spotting this here (not PR related), we gotta rework such things since Go changed in terms of get/install semantics
orangecms
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.