net: phy: micrel: Fix link-up failure at boot time #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At boot time the link not come up if it was not already set by U-Boot. The cable needed to be unplugged and then plugged again to make the link come up. This issue is caused by the Micrel KSZ9031 PHY which may fail to establish a link when the Asymmetric Pause capability is set, as described in a Silicon Errata (DS80000691D or DS80000692D), which advises to always disable the capability. This was fixed in mainline by 3aed3e2 ("net: phy: micrel: add Asym Pause workaround"). But this patch doesn't apply on a 4.19 kernel and need to be adapted to the old framework. Signed-off-by: Gregory CLEMENT <[email protected]>
AdhamAbozaeid
pushed a commit
to linux4wilc/linux-at91
that referenced
this pull request
Dec 2, 2019
…abled Compilation and linking erros are observed if compilation switches DISABLE_PWRSAVE_AND_SCAN_DURING_IP and WILC_DEBUGFS aren't defiend Fixes linux4sam#41 Signed-off-by: Adham Abozaeid <[email protected]>
|
Thank you. I merged this patch in linux-4.19-at91 branch (33220b3). |
noglitch
pushed a commit
that referenced
this pull request
Sep 11, 2020
[ Upstream commit a2ec905 ] Fix kernel oops observed when an ext adv data is larger than 31 bytes. This can be reproduced by setting up an advertiser with advertisement larger than 31 bytes. The issue is not sensitive to the advertisement content. In particular, this was reproduced with an advertisement of 229 bytes filled with 'A'. See stack trace below. This is fixed by not catching ext_adv as legacy adv are only cached to be able to concatenate a scanable adv with its scan response before sending it up through mgmt. With ext_adv, this is no longer necessary. general protection fault: 0000 [#1] SMP PTI CPU: 6 PID: 205 Comm: kworker/u17:0 Not tainted 5.4.0-37-generic #41-Ubuntu Hardware name: Dell Inc. XPS 15 7590/0CF6RR, BIOS 1.7.0 05/11/2020 Workqueue: hci0 hci_rx_work [bluetooth] RIP: 0010:hci_bdaddr_list_lookup+0x1e/0x40 [bluetooth] Code: ff ff e9 26 ff ff ff 0f 1f 44 00 00 0f 1f 44 00 00 55 48 8b 07 48 89 e5 48 39 c7 75 0a eb 24 48 8b 00 48 39 f8 74 1c 44 8b 06 <44> 39 40 10 75 ef 44 0f b7 4e 04 66 44 39 48 14 75 e3 38 50 16 75 RSP: 0018:ffffbc6a40493c70 EFLAGS: 00010286 RAX: 4141414141414141 RBX: 000000000000001b RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffff9903e76c100f RDI: ffff9904289d4b28 RBP: ffffbc6a40493c70 R08: 0000000093570362 R09: 0000000000000000 R10: 0000000000000000 R11: ffff9904344eae38 R12: ffff9904289d4000 R13: 0000000000000000 R14: 00000000ffffffa3 R15: ffff9903e76c100f FS: 0000000000000000(0000) GS:ffff990434580000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007feed125a000 CR3: 00000001b860a003 CR4: 00000000003606e0 Call Trace: process_adv_report+0x12e/0x560 [bluetooth] hci_le_meta_evt+0x7b2/0xba0 [bluetooth] hci_event_packet+0x1c29/0x2a90 [bluetooth] hci_rx_work+0x19b/0x360 [bluetooth] process_one_work+0x1eb/0x3b0 worker_thread+0x4d/0x400 kthread+0x104/0x140 Fixes: c215e93 ("Bluetooth: Process extended ADV report event") Reported-by: Andy Nguyen <[email protected]> Reported-by: Linus Torvalds <[email protected]> Reported-by: Balakrishna Godavarthi <[email protected]> Signed-off-by: Alain Michaud <[email protected]> Tested-by: Sonny Sasaka <[email protected]> Acked-by: Marcel Holtmann <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At boot time the link not come up if it was not already set by
U-Boot. The cable needed to be unplugged and then plugged again to
make the link come up.
This issue is caused by the Micrel KSZ9031 PHY which may fail to
establish a link when the Asymmetric Pause capability is set, as
described in a Silicon Errata (DS80000691D or DS80000692D), which
advises to always disable the capability.
This was fixed in mainline by 3aed3e2 ("net: phy: micrel: add
Asym Pause workaround"). But this patch doesn't apply on a 4.19 kernel
and need to be adapted to the old framework.
Signed-off-by: Gregory CLEMENT [email protected]