Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to tun GET_PYTHON_MODULES against all roles #41

Closed

Conversation

spetrosi
Copy link
Contributor

No description provided.

@spetrosi
Copy link
Contributor Author

@richm please take a look if this workflow needs to do anything special for #40

@spetrosi
Copy link
Contributor Author

Not tested yet, I just hope that this should work. Once this is managed, we can add comment ``[get_python_modules]` to #40 and it will run on the PR

@spetrosi
Copy link
Contributor Author

The best way to test this is to fork tft-tests, and in your fork, open a PR in reverse. I.e. do changed on the main branch, then open PR from main to any other branch. This way, the workflow still runs from the main branch, so from the branch where you do changes. You can try cherry-picking commits from #40 and #41 to your fork's branch and open a PR like I described.

@richm
Copy link
Contributor

richm commented Sep 20, 2024

I don't think we need a separate workflow for this. I have been testing with kernel_settings - linux-system-roles/kernel_settings#226 - I add a comment like this: [citest] GET_PYTHON_MODULES - which will run the ci tests with GET_PYTHON_MODULES=true set. This results in a .packages file for each "regular" log file. https://dl.fedoraproject.org/pub/alt/linuxsystemroles/logs/tf_kernel_settings-226_CentOS-Stream-10-2.17_20240920-001352/artifacts/

I was planning to add a comment to the weekly_ci PRs - [citest] GET_PYTHON_MODULES - at first, just a one time thing

@richm
Copy link
Contributor

richm commented Sep 20, 2024

The actual workflow change is linux-system-roles/kernel_settings#225
Once I get the bugs worked out, I'll revert this

@spetrosi
Copy link
Contributor Author

Rich implemented this elsewhere

@spetrosi spetrosi closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants