Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Ansible team, support for listing platforms in
role
meta/main.yml
files is being removed.Instead, they recommend using
galaxy_tags
https://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst
"Remove the galaxy_info field platforms from the role templates"
ansible/ansible#82453
Many roles already have tags such as "rhel", "redhat", "centos", and "fedora".
I propose that we ensure all of the system roles have these tags.
Some of our roles support Suse, Debian, Ubuntu, and others.
We should add tags for those e.g. the ssh role already has tags for "debian" and "ubuntu".
In addition - for each version listed under
platforms.EL
- add a tag likeelN
.Q: Why not use a delimiter between the platform and the version e.g.
el-10
?This is not allowed by ansible-lint:
So we cannot use uppercase letters either.
Q: Why not use our own meta/main.yml field?
No other fields are allowed by ansible-lint:
Q: Why not use some other field?
There are no other applicable or suitable fields.
Q: What happens when we want to support versions like
N.M
?Use the word "dot" instead of "." e.g.
el10dot3
.Similarly - use "dash" instead of "-".
We do not need tags such as
fedoraall
.The
fedora
tag implies that the role works on all supported versions of fedora.Otherwise, use tags such as
fedora40
if the role only supports specific versions.In addition - for roles that have different variable files for EL9, create
the corresponding EL10 files.
Added variables for el10. Looks like the default version on el10
is 16. No other versions (yet).
Signed-off-by: Rich Megginson [email protected]