fix: Use tuned files instead of using it as a module #220
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| import configobj | ||
|
|
||
| HAS_CONFIGOBJ = True |
Check notice
Code scanning / CodeQL
Unused global variable Note
|
|
||
| HAS_CONFIGOBJ = True | ||
| except ImportError: | ||
| HAS_CONFIGOBJ = False |
Check notice
Code scanning / CodeQL
Unused global variable Note
The previous version of the kernel_settings role used `tuned` as a python library, and had a `kernel_settings` module which was a wrapper around this code. However, `tuned` version 2.23 has changed its internal API and it is no longer possible to use it as a python library. Instead, the kernel_settings role has been refactored to read/write `tuned` config files, and let the `tuned` daemon manage the settings. In addition, `tuned` 2.23 changed the location of the profile directory, so the kernel_settings role will now determine the location of the profile directory depending on the `tuned` version. The old `kernel_settings` module is removed, along with all of the python unit testing code. A new `kernel_settings_get_config` module has been created which will simply parse and return the given config file as a `dict`. Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
use-tuned-but-not-module
branch
from
27817d0
to
7abfaf2
Compare
|
[citest] |
|
|
||
| - name: Set profile_mode to manual | ||
| copy: | ||
| content: > |
There was a problem hiding this comment.
| content: > | |
| content: manual |
is it the same thing?
There was a problem hiding this comment.
I want to ensure the file ends with a newline - not sure if content: manual will ensure that
| - name: Set profile_mode to manual | ||
| copy: | ||
| content: > | ||
| manual |
| - name: sysctl | ||
| new: "{{ kernel_settings_sysctl | difference([__kernel_settings_previous_replaced]) | list | ||
| if kernel_settings_sysctl != __kernel_settings_state_empty | ||
| else [] }}" |
There was a problem hiding this comment.
Why __sysctl_old is set to dict {} and new is set to list []?
There was a problem hiding this comment.
new is a list of dict - basically the same format as passed in by kernel_settings_sysctl et. al. - see https://github.com/linux-system-roles/kernel_settings/pull/220/files#diff-d5995b3130f3bd6a8890b9832f7250dbaf05507afd6e49f7e371152a459c50abR8
old is a dict as returned by kernel_settings_get_config and processed here - https://github.com/linux-system-roles/kernel_settings/pull/220/files#diff-d5995b3130f3bd6a8890b9832f7250dbaf05507afd6e49f7e371152a459c50abR15
| tuned-adm profile {{ __kernel_settings_active_profile | quote }} | ||
| when: | ||
| - not __kernel_settings_register_profile is changed | ||
| - not __kernel_settings_register_mode is changed |
There was a problem hiding this comment.
In the above task, there is or between these two checks, here they both should be changed to restart apply tuned?
There was a problem hiding this comment.
Restarting tuned will also apply the changes made by the template task
tuned must be restarted in order to apply the profile_mode or active_profile changes
If tuned has been restarted due to the above, we can skip doing the tuned-adm profile
|
[citest] |
The previous version of the kernel_settings role used
tunedasa python library, and had a
kernel_settingsmodule which was awrapper around this code. However,
tunedversion 2.23 has changedits internal API and it is no longer possible to use it as a python
library. Instead, the kernel_settings role has been refactored to
read/write
tunedconfig files, and let thetuneddaemon managethe settings.
In addition,
tuned2.23 changed the location of the profile directory,so the kernel_settings role will now determine the location of the
profile directory depending on the
tunedversion.The old
kernel_settingsmodule is removed, along with all of thepython unit testing code.
A new
kernel_settings_get_configmodule has been created which willsimply parse and return the given config file as a
dict.Signed-off-by: Rich Megginson [email protected]