fix: Compress applies to all storage modes, SyncInterval only to persistent

[richm]

Compress should apply to all storage modes

SyncInterval should apply only to persistent mode, and warn otherwise

Reformat the journald.conf template to make it easier to see which
settings apply to which modes.

Add test for ForwardToSyslog

Ensure the test cleans up properly

Signed-off-by: Rich Megginson [email protected]

[richm]

[citest]

[msekletar]

Nitpick, there is a bunch unrelated changes in a single commit. Maybe it would be better to split it.

Regarding, SyncInterval=. What is the point of calling sync() at all? For the most part, It is to ensure data persistence but there no persistence in volatile mode. So we should probably warn if SyncInterval is set in volatile mode because it is probably an error.

[richm]

Nitpick, there is a bunch unrelated changes in a single commit. Maybe it would be better to split it.

Regarding, SyncInterval=. What is the point of calling sync() at all? For the most part, It is to ensure data persistence but there no persistence in volatile mode. So we should probably warn if SyncInterval is set in volatile mode because it is probably an error.

ok - check out the latest commits

[richm]

[citest]

[msekletar]

LGTM