-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Compress applies to all storage modes, SyncInterval only to persistent #58
Conversation
[citest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, there is a bunch unrelated changes in a single commit. Maybe it would be better to split it.
Regarding, SyncInterval=. What is the point of calling sync() at all? For the most part, It is to ensure data persistence but there no persistence in volatile mode. So we should probably warn if SyncInterval is set in volatile mode because it is probably an error.
…cable to all storage types
ok - check out the latest commits |
[citest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Compress should apply to all storage modes
SyncInterval should apply only to persistent mode, and warn otherwise
Reformat the journald.conf template to make it easier to see which
settings apply to which modes.
Add test for ForwardToSyslog
Ensure the test cleans up properly
Signed-off-by: Rich Megginson [email protected]