Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update fmf plan to add a separate job to prepare managed nodes #216

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

spetrosi
Copy link
Collaborator

  • Add a preparation job to run on managed nodes
  • Update instructions to run tests locally

Signed-off-by: Sergei Petrosian [email protected]

@spetrosi
Copy link
Collaborator Author

[citest]

@spetrosi
Copy link
Collaborator Author

@tomjelinek Why are tests failing with this? Is there an additional setup task for tests?

TASK [fedora.linux_system_roles.ha_cluster : Fail if passwords are not specified] ***
task path: /tmp/tmp.ftwKGHCLYp/ansible_collections/fedora/linux_system_roles/roles/ha_cluster/tasks/shell_pcs/check-and-prepare-role-variables.yml:43
Friday 26 July 2024  13:33:10 -0400 (0:00:00.028)       0:00:05.834 *********** 
failed: [managed_node1] (item=ha_cluster_hacluster_password) => {
    "ansible_loop_var": "item",
    "changed": false,
    "item": "ha_cluster_hacluster_password"
}

MSG:

ha_cluster_hacluster_password must be specified

@richm
Copy link
Contributor

richm commented Jul 26, 2024

@tomjelinek Why are tests failing with this? Is there an additional setup task for tests?

TASK [fedora.linux_system_roles.ha_cluster : Fail if passwords are not specified] ***
task path: /tmp/tmp.ftwKGHCLYp/ansible_collections/fedora/linux_system_roles/roles/ha_cluster/tasks/shell_pcs/check-and-prepare-role-variables.yml:43
Friday 26 July 2024  13:33:10 -0400 (0:00:00.028)       0:00:05.834 *********** 
failed: [managed_node1] (item=ha_cluster_hacluster_password) => {
    "ansible_loop_var": "item",
    "changed": false,
    "item": "ha_cluster_hacluster_password"
}

MSG:

ha_cluster_hacluster_password must be specified

Which test is this?

@richm
Copy link
Contributor

richm commented Jul 26, 2024

@spetrosi ah - the vault support has not been added yet

@richm
Copy link
Contributor

richm commented Jul 26, 2024

@spetrosi
Copy link
Collaborator Author

[citest]

@spetrosi
Copy link
Collaborator Author

Ansible 2.17 shows that password_hash filter is going to be deprecated since Ansible 2.19.
I noticed this because passlib, a requirement for password_hash, is not pulled when installing ansible-2.17 with pip.
Apparently, passlib is not being supported, three years without commits.
More info in ansible/ansible#81949 and in ansible/ansible#82652.
We can use some cli like mkpasswd instead.

@spetrosi
Copy link
Collaborator Author

[citest]

* Add a preparation job to run on managed nodes
* Update instructions to run tests locally
* From tft workflow, remove condition for commenter author_association.
  This would require us to add all trusted users, running workflow is not dangerous.
* Keep the plan minimal, only run prep steps required to install beakerlib

Signed-off-by: Sergei Petrosian <[email protected]>
@spetrosi spetrosi merged commit 310073e into main Jul 30, 2024
19 checks passed
@idevat idevat mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants