Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change Supported to Compatible #188

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

richm
Copy link
Contributor

@richm richm commented Feb 7, 2024

Signed-off-by: Rich Megginson [email protected]

@richm richm mentioned this pull request Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8de4f5) 50.54% compared to head (43a75c0) 76.79%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #188       +/-   ##
===========================================
+ Coverage   50.54%   76.79%   +26.24%     
===========================================
  Files           1        3        +2     
  Lines          91      181       +90     
  Branches       12       12               
===========================================
+ Hits           46      139       +93     
+ Misses         45       42        -3     
Flag Coverage Δ
sanity 50.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm
Copy link
Contributor Author

richm commented Feb 9, 2024

@sean-freeman @marcelmamula ok?

@sean-freeman
Copy link
Contributor

Two birds with one stone, good idea 🙂 Will have to defer to @marcelmamula though

We should set a baseline version of the SLE distribution (I would suggest only Server edition, i.e. SLES) or OpenSUSE distribution (I would suggest only Leap, not Tumbleweed)

If I recall correctly, the switch to Linux Pacemaker 2.0 binaries occured in RHEL 8.0 and SLES 15 SP1 - so that would be the lowest compatible version in my opinion

@marcelmamula
Copy link
Contributor

@richm @sean-freeman Good idea, I was thinking of doing change like this once I am done with testing base SLES.
Can you change it to either of those:

  1. SLES 15 SP4+ with HA extension, SLES4SAP 15 SP4+
  2. SLES 15 SP4+ with HA extension, SLES4SAP 15 SP4+

Change the word "Supported" to "Compatible" for OS
Add SUSE to the list of Compatible OS

Add documentation about resilient storage repos for RHEL.

Signed-off-by: Rich Megginson <[email protected]>
@richm
Copy link
Contributor Author

richm commented Feb 12, 2024

@richm @sean-freeman Good idea, I was thinking of doing change like this once I am done with testing base SLES. Can you change it to either of those:

1. [SLES 15 SP4+](https://www.suse.com/products/server/) with [HA extension](https://www.suse.com/products/highavailability/), [SLES4SAP 15 SP4+](https://www.suse.com/products/sles-for-sap/)

2. SLES 15 SP4+ with HA extension, SLES4SAP 15 SP4+

please review latest commit

@sean-freeman
Copy link
Contributor

lgtm 👍

@marcelmamula
Copy link
Contributor

@richm LGTM , thank you

@richm richm merged commit 9b719a4 into linux-system-roles:main Feb 13, 2024
21 checks passed
@richm richm deleted the wording branch February 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants