refactor: Refactor bootloader_settings to run cmds from functions, use mock in unittests #97
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 78.43% 85.34% +6.91%
==========================================
Files 2 2
Lines 255 232 -23
==========================================
- Hits 200 198 -2
+ Misses 55 34 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
spetrosi
force-pushed
the
refactor-with-mock
branch
from
d43ba51
to
b76088f
Compare
|
[citest] |
Modify unittests to mock objects
spetrosi
force-pushed
the
refactor-with-mock
branch
from
b76088f
to
604425a
Compare
spetrosi
changed the title
spetrosi
changed the title
| @@ -363,57 +365,39 @@ def run_module(): | |||
| for bootloader_setting in module.params["bootloader_settings"]: | |||
| _unused, kernels_info, stderr = module.run_command("grubby --info=ALL") | |||
| if "Permission denied" in stderr: | |||
| module.fail_json(msg="You must run this as sudo", **result) | |||
| module.fail_json("You must run this as sudo") | |||
There was a problem hiding this comment.
I realize this is unrelated to the PR, but:
Is this message for the end user of the role? If so, what action are they supposed to take?
There was a problem hiding this comment.
Run this as root or with ansible_become. I guess all our roles must be run with as root, but I don't see other modules to check for this. Anyway, I decided to add such a check.
|
[citest] |
Enhancement: Improve code readability of the bootloader_settings module