Build and code cleanups #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether the system has LFS, and if so enable it. This should be ABI safe for the shared library as it does not expose any problematic type. Signed-off-by: Guillem Jover <[email protected]>
Having a test that never returns is not very nice, as it makes trying to run it during build or on a CI system hang. Signed-off-by: Guillem Jover <[email protected]>
Follow the same pattern in sysfs_read_attribute() as the rest of the code, and protect against wrong usage of the freed pointer. Signed-off-by: Guillem Jover <[email protected]>
The variable attr is only used in the other if branch, to check whether it is NULL. Signed-off-by: Guillem Jover <[email protected]>
The return value from write is never used nor checked, as we close() and immediately return. Signed-off-by: Guillem Jover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small code fixes and cleanups.