Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Replace RAW-HTML with image #67

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

SmithChart
Copy link
Member

.. raw::-directives are not allowed on pypi. Let's just switch to using the image-directive to generate basically the same output.

I am aware that the :align: directive does not work in the rendered file (at the moment). This seems to be a consequence of how Github handles external images: For images that are part of the repository :align: works, but pointing to something outside the repository doesn't.

@jluebbe
Copy link
Member

jluebbe commented Jan 18, 2024

Here is a discussion of this issue: github/markup#163

@SmithChart
Copy link
Member Author

Here is a discussion of this issue: github/markup#163

Correct. It seems it has been resolved for some images. One of the last comments points to a gist where it is still broken: github/markup#163 (comment)

`.. raw::`-directives are not allowed on pypi.
Let's just switch to using the image-directive to generate basically the
same output.

Signed-off-by: Chris Fiege <[email protected]>
@SmithChart SmithChart merged commit 796bf5d into linux-automation:master Jan 19, 2024
4 checks passed
@SmithChart SmithChart deleted the README branch January 19, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants