Make fd_fgets thread safe #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this can be optimized so there will be just one allocation per thread. |
|
The patch seems to get rid of the race being detected with helgrind. But, in the fd_fgets.h file, the access attribute needs its numbers corrected to 2, 3 since the first arg is a pointer to the struct. Also, I'd suggest switching around init and destroy declaration order and then add __attr_dealloc(fd_fgets_destroy, 1) at the end of the init declaration. |
|
LGTM |
radosroka
merged commit 9a15d63
into
linux-application-whitelisting:main
26 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.