Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Add support for (non-)legit workday of China #19

Merged

Conversation

EraserKing
Copy link

This pull request aims to support repeat option of (non-)legit workdays in Clock app, by bypassing international build detect.
Verified on MIUI EU 8.9.20 / MIX 2S.

I don't know much about bash shell so it may look ugly and need some polish. Thanks.

cleaner-fix.sh Outdated
done
mv deodex/system/app/DeskClock deodex/system/priv-app/DeskClock
rm -r deodex/system/app
Copy link
Author

@EraserKing EraserKing Sep 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the other places are always dealing with apps in priv-app folder, so I also move DeskClock.app from app folder into priv-app folder. This would eventually leads to a side effect: duplicated apps in both app and priv-app folders after flashing the zip package, but it seems have no harm.

@linusyang92
Copy link
Owner

@EraserKing Hi, thanks for the patch. But currently I have no plan to modify the clock app. I am not sure if this patch will bring any side effects. I'll leave this PR open.

@EraserKing
Copy link
Author

Hi, I've been using the modified clock for around 3 weeks, and I see no bug yet. But it's still up to you ;)

@linusyang92 linusyang92 mentioned this pull request Nov 30, 2018
@EraserKing EraserKing force-pushed the feature-legit-workday-clock branch from a3e9737 to b126b1d Compare January 19, 2019 12:27
@EraserKing EraserKing force-pushed the feature-legit-workday-clock branch from 19dd72b to 202098f Compare March 2, 2019 12:44
@EraserKing EraserKing force-pushed the feature-legit-workday-clock branch from 202098f to 11e9bce Compare March 2, 2019 12:48
@EraserKing
Copy link
Author

Hi, I have rewritten my commit, and now it allows to add some regular apps (/data/app) to be modified, plus the original way to update the priv-apps (/data/priv-app).
As an example, I added a command line switch to edit the clock app, and by default it's not turned on.

Additionally, to reduce file size, I created a new method to edit the international flag and modified the related methods to call this new method instead, to avoid duplicated modifications.

@linusyang92 linusyang92 merged commit 27b00ca into linusyang92:master Apr 15, 2019
@EraserKing EraserKing deleted the feature-legit-workday-clock branch January 4, 2020 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants