Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BulkCopy docs for asynchronous support #32

Merged
merged 10 commits into from
Aug 1, 2020
Merged

Update BulkCopy docs for asynchronous support #32

merged 10 commits into from
Aug 1, 2020

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Jul 12, 2020 •
edited
Loading

@Shane32 Shane32 marked this pull request as ready for review July 12, 2020 03:22
to11mtm
to11mtm approved these changes Jul 12, 2020
View reviewed changes
Copy link

@to11mtm to11mtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor change suggested (for consistency's sake)

source/articles/sql/Bulk-Copy.md Outdated Show resolved Hide resolved
MaceWindu
MaceWindu approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@MaceWindu MaceWindu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! could you add information which providers support async bulk copy (provider specific)

@Shane32
Copy link
Contributor Author

Shane32 commented Jul 12, 2020

Thanks! could you add information which providers support async bulk copy (provider specific)

I added this below the table:

Note that when using the provider-specific insert method, only MySql, PostgreSQL, SAP HANA, and Microsoft SQL Server support asynchronous operation; other providers will silently fall back to a synchronous operation.

If you think it should instead be embedded in the table, either as an additional column, or as notes in the ProviderSpecific column, please let me know.

@Shane32
Copy link
Contributor Author

Shane32 commented Jul 12, 2020

Another idea: I could replace "Yes" with "Synchronous only" or "Yes; synchronous only" for the IBM and Oracle providers.

@MaceWindu
Copy link
Contributor

I added this below the table

this is fine

@MaceWindu MaceWindu changed the base branch from master to linq2db_3_1_0_update August 1, 2020 10:16
@MaceWindu MaceWindu merged commit 393ccdd into linq2db:linq2db_3_1_0_update Aug 1, 2020
MaceWindu added a commit that referenced this pull request Aug 20, 2020
@MaceWindu @Shane32
Update for linq2db 3.1.0 release (#33)
af178a2 
* Update BulkCopy docs for asynchronous support (#32)

* Update BulkCopy for asynchronous support

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* Update Bulk-Copy.md

* document GetSchemaOptions.UseSchemaOnly

* submodules

Co-authored-by: Shane Krueger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@to11mtm to11mtm to11mtm approved these changes

@MaceWindu MaceWindu MaceWindu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shane32 @MaceWindu @to11mtm