Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPT 2101: add users data source #895

Merged
merged 14 commits into from
Jun 27, 2023

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Add users data source and apply the terraform framework. Build test cases to test basic, client filter, and substring filter.
Add missing fields to user attributes.

✔️ How to Test

make PKG_NAME="linode/user" testacc

go.mod Outdated Show resolved Hide resolved
@zliang-akamai
Copy link
Member

Another doubt I have is that verified_phone_number is a nullable field from API. I think we may want to fix this from linodego by making it as a pointer in the linodego struct.
image

@zliang-akamai
Copy link
Member

Others look good! Nice work on the sharing of resources between user and users!

@yec-akamai
Copy link
Contributor Author

Another doubt I have is that verified_phone_number is a nullable field from API. I think we may want to fix this from linodego by making it as a pointer in the linodego struct. image

Thanks for pointing it out! I put up the fix in linodego now linode/linodego#339

@yec-akamai yec-akamai requested a review from a team June 22, 2023 19:30
@zliang-akamai zliang-akamai requested a review from a team June 23, 2023 16:20
@zliang-akamai
Copy link
Member

zliang-akamai commented Jun 23, 2023

@yec-akamai yec-akamai requested review from a team and removed request for a team June 26, 2023 19:20
@zliang-akamai
Copy link
Member

zliang-akamai commented Jun 27, 2023

@yec-akamai don't forget the docs, lol

Feel free to do it in another PR.

@yec-akamai
Copy link
Contributor Author

@yec-akamai don't forget the docs, lol

Feel free to do it in another PR.

Thanks for the heads up! I'll merge this one and create another for the docs.

@yec-akamai yec-akamai merged commit a325503 into framework-migration-phase-3 Jun 27, 2023
@yec-akamai yec-akamai deleted the TPT-2101/add-users-data-source branch June 27, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants