fix: Retry on database wait operation requests

[lgarber-akamai]

📝 Description

This change alters the status polling logic in database-related resources to retry on 502 responses from the API within a certain tolerance. For the databases service, these errors do not necessarily reflect an internal error and instead may be the result of a transient error. This should significantly improve E2E test reliability.

Blocked by linode/linodego#319

✔️ How to Test

make PKG_NAME=linode/databasemysql testacc

[lgarber-akamai]

/acctest sha=cc0f58708740afaef8cfc9a8727511604f8a8b97 pkg=linode/databasemysql

[lgarber-akamai]

/acctest sha=cc0f58708740afaef8cfc9a8727511604f8a8b97 pkg=linode/databasepostgresql

[lgarber-akamai]

/acctest sha=cc0f58708740afaef8cfc9a8727511604f8a8b97 pkg=linode/databaseaccesscontrols

[lgarber-akamai]

/acctest sha=cc0f58708740afaef8cfc9a8727511604f8a8b97 pkg=linode/...

[zliang-akamai]

Nice work!

[zliang-akamai]

/acctest sha=0202d41a6742d78f56845b1f04f73916221bf6f8 pkg=linode/...

[zliang-akamai]

Wondering if we should use MinRetryDelayMilliseconds and MaxRetryDelayMilliseconds from the config.

terraform-provider-linode/linode/provider.go

Line 271 in c859258

MinRetryDelayMilliseconds: d.Get("min_retry_delay_ms").(int),

terraform-provider-linode/linode/provider.go

Line 134 in c859258

"min_retry_delay_ms": {

But since I can't find where these config values were used anywhere else, maybe we can just remove these config values from config schema instead? Was there any historic context info regarding these config?

[lgarber-akamai]

@zliang-akamai

Wondering if we should use MinRetryDelayMilliseconds and MaxRetryDelayMilliseconds from the config.

That's a good point! It'd probably be a good idea to keep retry timings configurable.

But since I can't find where these config values were used anywhere else, maybe we can just remove these config values from config schema instead?

These configs are passed into the linodego client and are used for retrying on 408 responses, etc.:

• https://github.com/linode/terraform-provider-linode/blob/dev/linode/helper/config.go#L94
• https://github.com/linode/linodego/blob/main/client.go#L319-L329

They're generally used to fine-tune API load for operations that might run into a lot of 408s (instance provisioning, etc.)

Hope that clears things up!

[zliang-akamai]

@lgarber-akamai Thank you for the context info!

[lgarber-akamai]

/acctest sha=c618f5abff8b851ae1703940ff75e04640bd24e1 pkg=linode/...