-
Notifications
You must be signed in to change notification settings - Fork 109
Added support for tier in lkeversion and lkeversions datasources #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for tier in lkeversion and lkeversions datasources #1776
Conversation
d4330a6 to
077f131
Compare
|
I was not able to find a way to entirely omit the |
077f131 to
fb723cf
Compare
|
Can we use statecheck for newly implemented tests? |
yec-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you for addressing the two data sources and quickly responded to the API change. Just a few small things:
yec-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expect, nice job!
ykim-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, verified locally. Nice work!
📝 Description
Added the
lkeversiondatasource. Also added support for thetierfield in thelkeversionsdatasource.The
lkeversiondatasource can be used to call bothGET /v4beta/lke/versions/<versionID>andGET /v4beta/lke/versions/<tier>/<versionID>endpoints.The
lkeversionsdatasource can be used to call bothGET /v4beta/lke/versions/<tier>andGET /v4beta/lke/versionsendpoints.✔️ How to Test
The following steps assume you have pulled down this PR locally.
Unit Tests
make test-unitIntegration Tests
make test-int PKG_NAME="lkeversion" TEST_CASE="TestAccDataSourceLinodeLkeVersion"make test-int PKG_NAME="lkeversions" TEST_CASE="TestAccDataSourceLinodeLkeVersions"Manual Tests
The following steps assume you have pulled down this PR locally.
v4beta):