Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow white space characters in the label of an SSH key #1659

Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

This is to allow white spaces in the label of an SSH key resource, as it's allowed by the API.

✔️ How to Test

make int-test PKG_NAME="linode/sshkey"

@zliang-akamai zliang-akamai requested a review from a team as a code owner November 13, 2024 07:26
@zliang-akamai zliang-akamai requested review from ykim-akamai and yec-akamai and removed request for a team November 13, 2024 07:26
@zliang-akamai zliang-akamai force-pushed the zhiwei/allow-space-in-ssh-key-label branch from 7af029d to 21c5d76 Compare November 13, 2024 16:16
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass locally

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passed locally!

@zliang-akamai zliang-akamai merged commit 5f1a812 into linode:dev Nov 19, 2024
6 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/allow-space-in-ssh-key-label branch November 19, 2024 16:13
@zliang-akamai zliang-akamai added the bugfix for any bug fixes in the changelog. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants