Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - add ID to exported instance attributes #1650

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

maxg-akamai
Copy link
Contributor

📝 Description

This PR adds the instance id as id to the instance docs as it's currently missing

✔️ How to Test

review the docs to confirm linode instance ID attribute is now present

@maxg-akamai maxg-akamai requested a review from a team as a code owner November 7, 2024 17:29
@maxg-akamai maxg-akamai requested review from yec-akamai and ezilber-akamai and removed request for a team November 7, 2024 17:29
@lgarber-akamai
Copy link
Contributor

lgarber-akamai commented Nov 7, 2024

Resolves #1649

@lgarber-akamai lgarber-akamai added the documentation for updates to the documentation in the changelog. label Nov 7, 2024
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the doc gap!

@yec-akamai
Copy link
Contributor

@maxg-akamai Could you have your commit signed? It's required by our branch protection.

@maxg-akamai
Copy link
Contributor Author

@maxg-akamai Could you have your commit signed? It's required by our branch protection.

hey @yec-akamai , done and done!

Would it be helpful if I opened a PR to add signed commits to CONTRIBUTING.md ?

@yec-akamai
Copy link
Contributor

@maxg-akamai Could you have your commit signed? It's required by our branch protection.

hey @yec-akamai , done and done!

Would it be helpful if I opened a PR to add signed commits to CONTRIBUTING.md ?

That would be very much appreciated :)

I'll merge this PR after the checks finish running.

@yec-akamai yec-akamai merged commit cc3ca44 into linode:dev Nov 8, 2024
6 checks passed
@maxg-akamai maxg-akamai deleted the maxg/instance-docs branch November 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation for updates to the documentation in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants