Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8384] - Update storybook to fix dependency vulnerabilities #10827

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Aug 23, 2024

Description 📝

Small PR to update storybook to get rid of a high severity dependabot alert

This update seems to be actually pretty major for storybook authors trying to clean up dependencies, which has been an ongoing problem. Hopefully this will help in the future.

Changes 🔄

  • Update storybook and related packages to 8.2.9

How to test 🧪

Verification steps

  • Run/build storybook locally to confirm no regression was introduced with this update

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Aug 23, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review August 23, 2024 17:03
@abailly-akamai abailly-akamai requested a review from a team as a code owner August 23, 2024 17:03
@abailly-akamai abailly-akamai requested review from hana-linode and hkhalil-akamai and removed request for a team August 23, 2024 17:03
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That diff in the lockfile is very pleasant to see 🎉

Storybook worked as expected locally ✅

Copy link

Coverage Report:
Base Coverage: 82.65%
Current Coverage: 82.65%

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Aug 23, 2024
@jaalah-akamai
Copy link
Contributor

You win for today 😆
Screenshot 2024-08-23 at 1 35 13 PM

Copy link
Contributor

@hana-linode hana-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than this known storybook warning issue

Screenshot 2024-08-23 at 3 56 17 PM

@abailly-akamai
Copy link
Contributor Author

@hana-linode yeah one fix could be to turn off the source map generation for storybook - not sure if it's that helpful. Def an issue with vite + storybook

@abailly-akamai abailly-akamai merged commit 9334669 into linode:develop Aug 23, 2024
19 checks passed
@abailly-akamai
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants