-
Notifications
You must be signed in to change notification settings - Fork 90
Add support for NodeBalancers UDP #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/unit/account_agreements_test.go
Outdated
"context" | ||
"testing" | ||
|
||
"github.com/jarcoal/httpmock" | ||
"github.com/linode/linodego" | ||
"github.com/stretchr/testify/assert" | ||
"testing" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were made implicitly by gofumpt -l -w .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything works well locally. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests all passed locally, nice work!
📝 Description
This pull request adds support for UDP NodeBalancer configs as well as the corresponding tests.
✔️ How to Test
The following test steps assume you have pulled down this PR locally.
NOTE: See the comments of TPT-3375 for instructions on configuring your account for UDP NodeBalancers.
Unit Testing
Integration Testing
Manual Testing