-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated profile_phone_number to regions from resty to request helpers #547
Migrated profile_phone_number to regions from resty to request helpers #547
Conversation
0edba58
to
07898a1
Compare
584fde5
to
6496cb0
Compare
932d9c8
to
47e2ccb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
// When opts (or opts.Page) is nil, all pages will be fetched and | ||
// returned in a single (endpoint-specific)PagedResponse | ||
// opts.results and opts.pages will be updated from the API response | ||
func (c *Client) listHelper(ctx context.Context, pager PagedResponse, opts *ListOptions, ids ...any) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated that the fixtures are free of sensitive data and all PagedResponse structs are preserved. Nice work!
📝 Description
Migrated profile_phone_number to regions to request helpers