New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: replace test execution handler with conditional #502

Merged

ykim-akamai merged 3 commits into linode:main from ykim-akamai:ci/replace_execution_handler_with_conditional

May 9, 2024

Contributor

ykim-akamai commented May 7, 2024 •

edited

Loading

📝 Description

Substitute hacky solution of executing integration tests and uploading test data with a more efficient solution using a conditional statement. This enhancement enables us to directly view test output within its associated step :)

✔️ How to Test

Build on forked - https://github.com/ykim-1/linodego/actions/runs/8993610349
TOD link (test instance) - http://198.19.5.79:7272/builds/663aba524f454e00016b8dbf?team=DX&buildName=linodego%201.33.1&bld_id=663aba524f454e00016b8dbf

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.


          replace test execution handler with conditional

3aa8d09

ykim-akamai requested a review from a team as a code owner

May 7, 2024 23:20

ykim-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team

May 7, 2024 23:20

ykim-akamai added 2 commits

May 7, 2024 16:46


          reorder env

e1608e8


          forgot rules of this repo

1e53afc

ykim-akamai added the repo-ci-improvement label

ykim-akamai commented

View reviewed changes

.github/workflows/ci.yml

    
                    - name: Add additional information to XML report

                      if: github.ref == 'refs/heads/main' && github.event_name == 'push'

                    - name: Upload test results to bucket

                      if: github.ref == 'refs/heads/main' && github.event_name == 'push' && always()

Contributor Author

ykim-akamai May 8, 2024

The secrets of this repo is only available to main branch, hence above checks are required to get the workflow to pass on open PRs against main

jriddle-linode approved these changes

View reviewed changes

zliang-akamai approved these changes

View reviewed changes

ykim-akamai merged commit 87593bd into linode:main

4 checks passed

renovate bot referenced this pull request in anza-labs/lke-operator


          fix(deps): update module github.com/linode/linodego to v1.34.0 (#16)

a1cc815

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/linode/linodego](https://github.com/linode/linodego) |
`v1.33.1` -> `v1.34.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2flinode%2flinodego/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2flinode%2flinodego/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2flinode%2flinodego/v1.33.1/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2flinode%2flinodego/v1.33.1/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>linode/linodego (github.com/linode/linodego)</summary>

###
[`v1.34.0`](https://github.com/linode/linodego/releases/tag/v1.34.0)

[Compare
Source](https://github.com/linode/linodego/compare/v1.33.1...v1.34.0)

#### What's Changed

##### ⚠️  Breaking Change

- \[BREAKING] Add support for LKE Control Plane ACL by
[@&#8203;lgarber-akamai](https://github.com/lgarber-akamai) in
[https://github.com/linode/linodego/pull/495](https://github.com/linode/linodego/pull/495)

##### 🐛 Bug Fixes

- Prevent unexpected warning from Resty when calling
`Client.SetDebug(false)` by
[@&#8203;lgarber-akamai](https://github.com/lgarber-akamai) in
[https://github.com/linode/linodego/pull/508](https://github.com/linode/linodego/pull/508)

##### 💡 Improvements

- Mask the value of the Authorization header if debug is enabled by
[@&#8203;rosskirkpat](https://github.com/rosskirkpat) in
[https://github.com/linode/linodego/pull/501](https://github.com/linode/linodego/pull/501)
- Expose region capabilities enum by
[@&#8203;yec-akamai](https://github.com/yec-akamai) in
[https://github.com/linode/linodego/pull/507](https://github.com/linode/linodego/pull/507)

##### ⚙️  Repo/CI Improvements

- replace test execution handler with conditional by
[@&#8203;ykim-1](https://github.com/ykim-1) in
[https://github.com/linode/linodego/pull/502](https://github.com/linode/linodego/pull/502)

##### 📦 Dependency Updates

- bump golang.org/x/net from 0.24.0 to 0.25.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/linode/linodego/pull/500](https://github.com/linode/linodego/pull/500)
- bump github.com/go-resty/resty/v2 from 2.12.0 to 2.13.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/linode/linodego/pull/505](https://github.com/linode/linodego/pull/505)
- bump golangci/golangci-lint-action from 5 to 6 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/linode/linodego/pull/506](https://github.com/linode/linodego/pull/506)

#### New Contributors

- [@&#8203;rosskirkpat](https://github.com/rosskirkpat) made their
first contribution in
[https://github.com/linode/linodego/pull/501](https://github.com/linode/linodego/pull/501)

**Full Changelog**:
linode/linodego@v1.33.1...v1.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/anza-labs/lke-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImFyZWEvZGVwZW5kZW5jeSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

shanduur mentioned this pull request

feat: allow setting root CA from string #563

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo-ci-improvement