Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add SiteType in regions #482

Merged
merged 1 commit into from
Mar 22, 2024
Merged

new: Add SiteType in regions #482

merged 1 commit into from
Mar 22, 2024

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Mar 21, 2024

📝 Description

This change exposes a new field SiteType in the regions related response. This field will be able to tell apart different site type.

✔️ How to Test

make ARGS="-run TestRegions_List" fixtures

Manual Test:

  1. In a sandbox environment, run the following code:
import (
	"context"
	"os"

	"github.com/linode/linodego"
)

func main() {
	client := linodego.NewClient(nil)
	client.SetToken(os.Getenv("LINODE_TOKEN"))

	regions, err := client.ListRegions(context.Background(), nil)
	if err != nil {
		panic(err)
	}

	println(regions[0].ID, regions[0].SiteType)
}
  1. Observe the new field printed as expected.

@yec-akamai yec-akamai requested a review from a team as a code owner March 21, 2024 18:53
@yec-akamai yec-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team March 21, 2024 18:53
@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Mar 21, 2024
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (tests passed of course)

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yec-akamai yec-akamai merged commit d349cae into main Mar 22, 2024
6 checks passed
@yec-akamai yec-akamai deleted the TPT-2766/add-gecko-change branch March 22, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants