-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Group
Field of Instance Options; Retype Group
in InstanceUpdateOptions
to be String Pointer
#457
Deprecate Group
Field of Instance Options; Retype Group
in InstanceUpdateOptions
to be String Pointer
#457
Conversation
Group
Field of Instance Options; Retype Group
to be String Pointer
Group
Field of Instance Options; Retype Group
to be String PointerGroup
Field of Instance Options; Retype Group
in InstanceUpdateOptions
to be String Pointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! We'll need to make sure we communicate that this is a breaking change in the release notes given how wide-reaching it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Tests passed locally
📝 Description
Users may want to delete the value of
group
, a deprecated attribute of a Linode instance. We can make it to be a pointer to allow users pass in an empty string to remove the attribute on the cloud.Original issue is reported in our TF provider repository: linode/terraform-provider-linode#1296
✔️ How to Test
Automated Testing
make ARGS="-run TestInstance" fixtures
Manual Testing
Expected result:
instance group: ''