Fields for Unified Migration Project #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
zliang-akamai
changed the base branch from
proj/vpc
to
proj/unified-migration
lgarber-akamai
approved these changes
Nov 20, 2023
jriddle-linode
approved these changes
Nov 28, 2023
|
Thanks for the review! Note that test fixtures will be added once we get this feature on the production server. |
zliang-akamai
added a commit
that referenced
this pull request
Dec 18, 2023
* Add fields for unified migration (#428) * Add fixture for TestInstance_Resize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to support the feature from the unified migration project. Tests are failing because lack of fixture, which we can generate when the change is in the production.
✔️ How to Test
make ARGS="-run TestInstance_Resize" fixturesagainst alpha.Don't forget making get regions function only to return
us-east.We can't test migrate in the test cases because it requires an admin portal operation prior to the API call, and it don't return any useful value, which makes mocked response ruled out. And it's just a field, should be very easy to test it manually.