Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change go version to be stable in test CI #357

Merged
merged 3 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.18'
go-version: 'stable'
- run: go version
- name: Run tidy
run: make tidy
Expand Down
6 changes: 6 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ linters:
- nosnakecase
####################

# conflicted with go fmt
- nolintlint

# workaround to avoid linter failures of getting malformed json
- musttag

- bodyclose
- contextcheck
- nilerr
Expand Down
2 changes: 1 addition & 1 deletion pagination.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type PageOptions struct {
}

// ListOptions are the pagination and filtering (TODO) parameters for endpoints
//nolint
// nolint
type ListOptions struct {
*PageOptions
PageSize int `json:"page_size"`
Expand Down
2 changes: 1 addition & 1 deletion waitfor.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ func (client Client) WaitForLKEClusterConditions(
// WaitForEventFinished waits for an entity action to reach the 'finished' state
// before returning. It will timeout with an error after timeoutSeconds.
// If the event indicates a failure both the failed event and the error will be returned.
//nolint
// nolint
func (client Client) WaitForEventFinished(
ctx context.Context,
id any,
Expand Down