Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add betas to support self serve beta program #356

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Aug 11, 2023

📝 Description

Beta program is a new product or service that's not generally available to all customers. User with permissions can enroll into a beta program and access the functionalities.

Add betas to support listing active beta programs and getting details of a single beta program.
Two endpoints are implemented in this PR:

GET /beta
GET /betas/:id

JIRA: https://jira.linode.com/browse/TPT-2181

Disable musttag as a workaround to avoid an issue that metalinter is getting malformed json: https://github.com/linode/linodego/actions/runs/5837079890/job/15831940532

✔️ How to Test

make testunit
make testint

@yec-akamai yec-akamai requested a review from a team as a code owner August 11, 2023 20:40
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change and this should be good to go!

betas.go Outdated Show resolved Hide resolved
@yec-akamai yec-akamai requested review from lgarber-akamai and a team August 16, 2023 20:59
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@lgarber-akamai lgarber-akamai requested a review from a team August 17, 2023 16:19
@yec-akamai yec-akamai requested review from a team and removed request for a team August 21, 2023 16:16
@zliang-akamai
Copy link
Member

The change looks good! But do we want to merge this into main before it's available in production?

@yec-akamai
Copy link
Contributor Author

The change looks good! But do we want to merge this into main before it's available in production?

Good question! The self serve beta endpoints are actually available in production. We test against alpha is because there isn't data (active beta programs) in production for now. It shouldn't block us from merging the change. On the other hand, we are not always going to have available betas anyway. So I think it's good to merge the implementation now.

@yec-akamai yec-akamai merged commit 8475f96 into main Aug 22, 2023
5 checks passed
@yec-akamai yec-akamai deleted the TPT-2181/add-betas branch August 22, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants