new: Add support for polling on events with a secondary entity ID #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jriddle-linode
approved these changes
Jul 25, 2023
zliang-akamai
approved these changes
Aug 1, 2023
Comment on lines
+668
to
+671
| if !eventMatchesSecondary(p.SecondaryEntityID, event) { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
Is adding an additional API filter when SecondaryEntityID != nil a better and workable idea? (this is just a discussion, and feel free to merge the PR)
There was a problem hiding this comment.
Good question! Unfortunately filtering on a secondary entity ID isn't supported through the API as of now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This change adds support for polling on events while filtering on both a primary and secondary entity ID. This includes a new
NewEventPollerWithSecondary(...)function and a newSecondaryEntityIDevent poller field.NOTE: The filtering logic for secondary entity IDs has been implemented on the client as this functionality is not currently offered by the API.
✔️ How to Test