Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: verified_phone_number type in account_users #339

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix: verified_phone_number type in account_users #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion account_users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type User struct {
TFAEnabled bool `json:"tfa_enabled"`
SSHKeys []string `json:"ssh_keys"`
PasswordCreated *time.Time `json:"-"`
VerifiedPhoneNumber string `json:"verified_phone_number"`
VerifiedPhoneNumber *string `json:"verified_phone_number"`
}

// UserCreateOptions fields are those accepted by CreateUser
Expand Down
4 changes: 2 additions & 2 deletions test/integration/account_users_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func TestUser_Get(t *testing.T) {
if user.TFAEnabled {
t.Error("expected TFA is disabled")
}
if user.VerifiedPhoneNumber != "" {
if user.VerifiedPhoneNumber != nil {
t.Error("expected phone number is not set")
}
}
Expand Down Expand Up @@ -147,7 +147,7 @@ func TestUsers_List(t *testing.T) {
if newUser.TFAEnabled {
t.Error("expected TFA is disabled")
}
if newUser.VerifiedPhoneNumber != "" {
if newUser.VerifiedPhoneNumber != nil {
t.Error("expected phone number is not set")
}
}
Expand Down