test: Allow integration and unit tests to run against EOL or desired python version #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
yec-akamai and
ezilber-akamai
and removed request for
a team
ykim-akamai
commented
Nov 1, 2024
| @@ -11,11 +11,20 @@ on: | |||
| description: 'The hash value of the commit' | |||
| required: false | |||
| default: '' | |||
| run-eol-python-version: | |||
There was a problem hiding this comment.
Would it make sense to include another variable here for us to specify which python version we want to run against? E.g. 3.12
There was a problem hiding this comment.
Yeah, I think that's a good idea! It will be really nice to be able to run the tests against all supported python versions easily.
ykim-akamai
changed the title
ykim-akamai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds workflow_dispatch input to allow e2e tests run against EOL python version as an option. Also remove 3.8 from unit test matrix as it is no longer supported.
e.g.
✔️ How to Test
Forked e2e run with EOL:
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.