Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point build at akamai-apis OpenAPI spec #661

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Oct 23, 2024

📝 Description

Depends on #629

This pull request points the Linode CLI's build configuration at the OpenAPI spec stored in the akamai/akamai-apis repository.

This includes the following changes:

  • The removal of all secrets.GITHUB_TOKEN CI references when installing the CLI
    • This is no longer necessary because we no longer need to access GitHub's API directly
  • The removal of the remote-release-trigger.yml workflow
  • The removal of the resolve_spec_url script

✔️ How to Test

The following test steps assume you have pulled down this PR locally and run make install.

Integration Testing

make testint

Unit Testing

make testunit

Manual Testing

After running make install, you should be able to run arbitrary commands against an install of the Linode CLI built from the new spec location.

@lgarber-akamai lgarber-akamai added the improvement for improvements in existing functionality in the changelog. label Oct 23, 2024
@lgarber-akamai lgarber-akamai force-pushed the ref/point-at-akamai-apis branch 3 times, most recently from ec9733f to bebf2a2 Compare October 23, 2024 15:54
@lgarber-akamai lgarber-akamai force-pushed the ref/point-at-akamai-apis branch from bebf2a2 to 8d14c9a Compare October 23, 2024 15:57
@lgarber-akamai lgarber-akamai added the do-not-merge PRs that should not be merged until the commented issue is resolved label Oct 23, 2024
@lgarber-akamai lgarber-akamai marked this pull request as ready for review October 23, 2024 16:01
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner October 23, 2024 16:01
@lgarber-akamai lgarber-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team, jriddle-linode and zliang-akamai October 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge PRs that should not be merged until the commented issue is resolved improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant