New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApacheSdkHttpClient improvements #13

Open

ydylla wants to merge 3 commits into linktosriram:master from ydylla:apache

ydylla commented Mar 23, 2023

Hi,
this contains some fixes and improvements for the apache client impl:

It implements streaming PUT requests
Fixes a bug where the apache client did not accept an existing content-length header on requests
Fixes a bug which caused the prefix query parameter for ListObjectsV2 requests to be url encoded twice, altering its meaning

ydylla added 3 commits

March 23, 2023 13:04


          feat: streaming puts for apache http client

3c7cbda


          fix: apache client content-length handling

965b87f


          fix: use own url query encoding to prevent double encoding

7c44a97

This way it also always matches the value that Aws4Signer uses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet