Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API gateway compatability #1886

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

GTRekter
Copy link
Contributor

This is a first draft of the compatibility of API gateway and the features supported.

@wmorgan
Copy link
Member

wmorgan commented Nov 29, 2024

A couple thoughts. First, I think it's probably time for a separate Gateway API reference page, which includes this information as well as the paragraph above it. Let's make the HTTPRoute reference page just about HTTPRoute, and have it (and any GRPCRoute, TCPRoute, etc reference page) just link to the new Gateway API page.

Second, it's not clear to me what this table is trying to convey. What does it mean to say that Basic Routing is "Supported" in one mode but is "v1.1.0-experimental" in another mode? Those seem to be answering two different questions.

Third, whether in this page or the other, something really unclear to me is the relationship between "Gateway API version 0.7" and, say, "httproutes.gateway.networking.k8s.io/v1beta1". Is that something to be documented here? Or somewhere else.

Finally: As this PR evolves I will be looking to provide actionable advice to users. What is it, exactly, do we want them to do?

@GTRekter
Copy link
Contributor Author

I've used the linkerd HTTP as reference and created a new page for Gateway API HTTPRoute, and added two examples.

GTRekter and others added 28 commits December 21, 2024 01:49
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
* November Edge Release Roundup

Signed-off-by: Flynn <[email protected]>

* Fix headings

Signed-off-by: Flynn <[email protected]>

* Review feedback (and feature the 1127 roundup)

Signed-off-by: Flynn <[email protected]>

---------

Signed-off-by: Flynn <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
* Chris Campbell's Tilt, Linkerd, and NGINX blog, part 1

Signed-off-by: Flynn <[email protected]>

* Review feedback + featured post

Signed-off-by: Flynn <[email protected]>

---------

Signed-off-by: Flynn <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Co-authored-by: Flynn <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
* Rate Limiting docs

---------

Co-authored-by: Flynn <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
* add egress documentation

Signed-off-by: Zahari Dichev <[email protected]>

* Apply suggestions from code review by @kflynn

Co-authored-by: Flynn <[email protected]>

* lint

Signed-off-by: Zahari Dichev <[email protected]>

* Apply suggestions from code review

Co-authored-by: Flynn <[email protected]>

* Warnings per William

Signed-off-by: Flynn <[email protected]>

* Effing lint...

Signed-off-by: Flynn <[email protected]>

* 🤦‍♂️ Syntax correctness would help.

Signed-off-by: Flynn <[email protected]>

* C'mon, lint, tell me all the errors at once...

Signed-off-by: Flynn <[email protected]>

* Warning tweaks after William's feedback

Signed-off-by: Flynn <[email protected]>

* 🤦‍♂️

Signed-off-by: Flynn <[email protected]>

---------

Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Flynn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
* Add federated services docs

Signed-off-by: Alex Leong <[email protected]>

* feedback

Signed-off-by: Alex Leong <[email protected]>

* servce

Signed-off-by: Alex Leong <[email protected]>

* feedback

Signed-off-by: Alex Leong <[email protected]>

* Feedback

Signed-off-by: Alex Leong <[email protected]>

* Update linkerd.io/content/2-edge/features/multicluster.md

* Update linkerd.io/content/2-edge/tasks/federated-services.md

Co-authored-by: Alejandro Pedraza <[email protected]>

---------

Signed-off-by: Alex Leong <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Alejandro Pedraza <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Co-authored-by: Flynn <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Travis Beckham <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
* fix typo

* Fix typo

Signed-off-by: Ivan Porta <[email protected]>
travisbeckham and others added 4 commits December 21, 2024 01:49
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
@GTRekter GTRekter force-pushed the ivanp/apigateway-compatability branch from a0b0946 to f7d3826 Compare December 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants