-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding feature documentation and task instructions for topology aware hints #1579
base: main
Are you sure you want to change the base?
Conversation
… hints Signed-off-by: Alen Haric <[email protected]>
3a430fc
to
73b5dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a bunch of comments with little copyediting things -- overall, I really like having this content, many thanks!! 🙂
…mended by Flynn. Signed-off-by: Alen Haric <[email protected]>
Signed-off-by: Alen Haric <[email protected]>
Signed-off-by: Alen Haric <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Still found a coupla things that need a bit of attention. 🙂
The main things to be aware of are: | ||
|
||
- Linkerd assumes that traffic to a given zone will be roughly proportional to the capacity of the nodes in the zone (which can be a concern when using horizontal pod autoscaling, as the HPA may start nodes in the "wrong" zone); and | ||
- The Kubernetes endpoint slice controller does not take... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...does not take what?
] | ||
+++ | ||
|
||
Kuberentes clusters are increasingly deployed in multi-zone environments with network traffic often relying on obscure endpoint matching and routing for a given service. Linkerd's implementation of Kubernetes ([Topology Aware Hints][topology aware hints]) provides users with a mechanism for asserting more control over endpoint selection and routing within a cluster that spans multiple zones. Users can now implement routing constraints and prefer endpoints in a specific zone in order to limit cross-zone networking costs or improve performance through lowered cross-zone latency and bandwidth constraints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Kuberentes/Kubernetes/
(or, better, just directly copy all your 2.12 docs to 2.13?)
what's holding this back? 😃 |
We still need some corrections to it, and it looks like @deusxanima is out this week. I'll see if I can't get things moving to bring it in soon, though. |
any news? |
Problem: topology aware hints feature implementation is not currently documented on linkerd.io
Solution: adding feature documentation and task instructions for topology aware hints
Fixes: #1519
Signed-off-by: Alen Haric [email protected]