Require TLS when using curl #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our usage of `curl` could be vulnerable to protocol downgrade attacks. This change updates most of our usage of curl--especially when fetching executable resources--with the following command-line flags: * `--proto '=https'` forces use of HTTPS. This ensures that dropping `https://` from a URL will cause the command to fail instead of reverting to use unsecured HTTP. * `--tlsv1.3` disables the use of older TLS versions. This flag was added to curl in 2016, which now seems old enough to be a reasonable default. * `-f|--fail` ensures that curl does not output anything to stdout when a non-2xx response is received. * `-S|--show-error` causes errors to be printed to stderr (when `-s|--silent` is used). Related to linkerd/linkerd2#7593 Signed-off-by: Oliver Gould <[email protected]>
Signed-off-by: Oliver Gould <[email protected]>
Signed-off-by: Oliver Gould <[email protected]>
alpeb
reviewed
Jan 18, 2022
cpretzer
reviewed
Jan 18, 2022
|
We should update this to be |
wmorgan
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Edit: oops I see @cpretzer beat me to the scoop.
On my 2020 M1 Mac running Big Sur (i.e. reasonably up-to-date), I get:
❯ curl --proto '=https' --tlsv1.3 -sSfL https://buoyant.cloud/install
curl: (4) LibreSSL was built without TLS 1.3 support
hawkw
approved these changes
Jan 18, 2022
|
@cpretzer does this look okay now? |
|
Apologies for the late review here. The updated It's likely I could install a compatible version of |
|
@klingerf this is flagging that this isn't using https! So it's working as intended :) we should update that link to be https://buoyant.cloud... |
olix0r
added a commit
that referenced
this pull request
Mar 17, 2022
#1277 missed one URL. This fixes it. Signed-off-by: Oliver Gould <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our usage of
curlcould be vulnerable to protocol downgrade attacks. Thischange updates most of our usage of curl--especially when fetching executable
resources--with the following command-line flags:
--proto '=https'forces use of HTTPS. This ensures that droppinghttps://from a URL will cause the command to fail instead of reverting to use
unsecured HTTP.
--tlsv1.2disables the use of older TLS versions.-f|--failensures that curl does not output anything to stdout when anon-2xx response is received.
-S|--show-errorcauses errors to be printed to stderr (when-s|--silentis used).
Related to linkerd/linkerd2#7593
Signed-off-by: Oliver Gould [email protected]