policy: Per route authorization #8901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
hawkw
reviewed
Jul 18, 2022
| ) -> HashMap<AuthorizationRef, ClientAuthorization> { | ||
| let mut authzs = HashMap::default(); | ||
|
|
||
| for (name, spec) in self.authorization_policies.iter() { |
There was a problem hiding this comment.
style nit, not important: &HashMap implements IntoIterator, so i believe this could just be
Suggested change
| for (name, spec) in self.authorization_policies.iter() { | |
| for (name, spec) in self.authorization_policies { |
olix0r
reviewed
Jul 18, 2022
olix0r
reviewed
Jul 18, 2022
olix0r
reviewed
Jul 18, 2022
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Jul 18, 2022
|
Great! Seems to work as expected using a config like https://gist.github.com/olix0r/0d13b32037e91ad802a907077f29b821#file-emojivoto-policy-yml |
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Jul 19, 2022
Comment on lines
88
to
107
| let curl = curl::Runner::init(&client, &ns).await; | ||
| let (allowed, denied) = tokio::join!( | ||
| curl.run( | ||
| "curl-allowed", | ||
| "http://nginx/allowed", | ||
| LinkerdInject::Enabled | ||
| ), | ||
| curl.run("curl-denied", "http://nginx/denied", LinkerdInject::Enabled), | ||
| ); | ||
| let (allowed_status, denied_status) = tokio::join!(allowed.exit_code(), denied.exit_code()); | ||
| assert_eq!( | ||
| allowed_status, 0, | ||
| "curling allowed route must contact nginx" | ||
| ); | ||
| assert_ne!( | ||
| denied_status, 0, | ||
| "curl which does not match route must not contact nginx" | ||
| ); | ||
| }) | ||
| .await; |
There was a problem hiding this comment.
There are probably a few more states worth considering here:
- allowed by a server-scoped authorization
- allowed by a server-scoped authorization but not present in routes (should get a 404).
not a blocker
olix0r
reviewed
Jul 19, 2022
olix0r
reviewed
Jul 19, 2022
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Jul 20, 2022
| "http://nginx/allowed", | ||
| LinkerdInject::Enabled | ||
| ), | ||
| curl.run("curl-denied", "http://nginx/denied", LinkerdInject::Enabled), |
There was a problem hiding this comment.
Sorry, I still think this is a little off: this case is hitting an endpoint on no route. we probably want an additional route object that matches /denied (or an empty route to match all endpoints?). OR we should rename "denied" to something like "no-route"
Signed-off-by: Alex Leong <[email protected]>
olix0r
approved these changes
Jul 20, 2022
hawkw
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8890
When building the
InboundHttpRoute, we find all authorizations which target that route and copy the associated authentications onto the route and return them in the api. This allows AuthorizationPolicies to target HttpRoutes.We also add admission, api, and e2e tests.