Trigger destination restart upon every upgrade #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6940 Upon every upgrade the certs used by the policy controller validator change, but the controller doesn't detect that, which breaks the webhook requests. As a temporary solution, we force the pod to restart by adding a `checksum/config` annotation to the manifest, like the injector currently has.
adleong
approved these changes
Sep 22, 2021
Merged
alpeb
added a commit
that referenced
this pull request
Sep 23, 2021
Merged
alpeb
added a commit
that referenced
this pull request
Sep 23, 2021
|
Thanks for the report @iAnomaly . That was indeed an oversight. I'll ping the team about it, but feel free to post a PR addressing that (and for other controllers as well if needed) 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6940
Upon every upgrade the certs used by the policy controller validator
change, but the controller doesn't detect that, which breaks the webhook
requests. As a temporary solution, we force the pod to restart by adding
a
checksum/configannotation to the manifest, like the injectorcurrently has.