Use a shared informer when getting node topology#5722
Merged
kleimkuhler merged 1 commit intolinkerd:mainfrom Feb 12, 2021
Merged
Use a shared informer when getting node topology#5722kleimkuhler merged 1 commit intolinkerd:mainfrom
kleimkuhler merged 1 commit intolinkerd:mainfrom
Conversation
fpetkovski
force-pushed
the
ld-5684
branch
4 times, most recently
from
262ace6 to
b1f86b3
Compare
Member
|
Hey @fpetkovski thank you for taking care of this! 🥳 I really appreciate it. This looks good to me. It is pretty much the way I would have done it, save for different (and possibly less inspired) names. |
kleimkuhler
approved these changes
Feb 11, 2021
Contributor
kleimkuhler
left a comment
kleimkuhler
left a comment
There was a problem hiding this comment.
This looks good! It makes sense that this address the bottleneck we're seeing in that issue.
Getting information about node topology queries the k8s api directly. In an environment with high traffic and high number of pods, the k8s api server can become overwhelmed or start throttling requests. This MR introduces a node informer to resolve the bottleneck and fetch node information asynchronously. Fixes linkerd#5684 Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
adleong
approved these changes
Feb 11, 2021
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Fantastic!!! Thank you, @fpetkovski! 💯
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Mar 23, 2021
Getting information about node topology queries the k8s api directly. In an environment with high traffic and high number of pods, the k8s api server can become overwhelmed or start throttling requests. This MR introduces a node informer to resolve the bottleneck and fetch node information asynchronously. Fixes linkerd#5684 Signed-off-by: fpetkovski <filip.petkovsky@gmail.com> Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
Getting information about node topology queries the k8s api directly. In an environment with high traffic and high number of pods, the k8s api server can become overwhelmed or start throttling requests. This MR introduces a node informer to resolve the bottleneck and fetch node information asynchronously. Fixes linkerd#5684 Signed-off-by: fpetkovski <filip.petkovsky@gmail.com> Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
Contributor
|
@adleong much appreciated to see this solved! We just discovered that we ran into the same issue. Sadly, we currently cannot update to L5d |
kleimkuhler
pushed a commit
that referenced
this pull request
Apr 29, 2021
Getting information about node topology queries the k8s api directly. In an environment with high traffic and high number of pods, the k8s api server can become overwhelmed or start throttling requests. This MR introduces a node informer to resolve the bottleneck and fetch node information asynchronously. Fixes #5684 Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
kleimkuhler
added a commit
that referenced
this pull request
Apr 29, 2021
Getting information about node topology queries the k8s api directly. In an environment with high traffic and high number of pods, the k8s api server can become overwhelmed or start throttling requests. This MR introduces a node informer to resolve the bottleneck and fetch node information asynchronously. Fixes #5684 Signed-off-by: fpetkovski <filip.petkovsky@gmail.com> Co-authored-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
kleimkuhler
pushed a commit
that referenced
this pull request
Apr 29, 2021
Getting information about node topology queries the k8s api directly. In an environment with high traffic and high number of pods, the k8s api server can become overwhelmed or start throttling requests. This MR introduces a node informer to resolve the bottleneck and fetch node information asynchronously. Fixes #5684 Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting information about node topology queries the k8s api directly.
In an environment with high traffic and high number of pods, the
k8s api server can become overwhelmed or start throttling requests.
This MR introduces a node informer to resolve the bottleneck and
fetch node information asynchronously.
Fixes #5684